public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>, Markus Frank <m.frank@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] fix #3934 tape owner-selector to Authid
Date: Tue, 15 Mar 2022 15:38:02 +0100	[thread overview]
Message-ID: <8be9527f-3d77-4173-9a73-ffab494334b6@proxmox.com> (raw)
In-Reply-To: <20220315130829.49080-1-m.frank@proxmox.com>

On 15.03.22 14:08, Markus Frank wrote:
> changed pmxUserSelector to pbsAuthidSelector, because it is currently
> not possible to restore with a api token via gui.
> 
> Signed-off-by: Markus Frank <m.frank@proxmox.com>
> ---
>  www/tape/window/TapeRestore.js | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/www/tape/window/TapeRestore.js b/www/tape/window/TapeRestore.js
> index 7a5d3cbf..2322d352 100644
> --- a/www/tape/window/TapeRestore.js
> +++ b/www/tape/window/TapeRestore.js
> @@ -398,10 +398,10 @@ Ext.define('PBS.TapeManagement.TapeRestoreWindow', {
>  			    renderer: Ext.String.htmlEncode,
>  			},
>  			{
> -			    xtype: 'pmxUserSelector',
> +			    xtype: 'pbsAuthidSelector',
>  			    name: 'owner',
>  			    fieldLabel: gettext('Owner'),
> -			    emptyText: gettext('Current User'),
> +			    emptyText: gettext('Current Authentication'),

We do not use "Authentication" in any gettext currently, besides indirectly in TFA,
and for that specific use case we agreed on using "Auth ID", so can you please change
it to that in a v2?

>  			    value: null,
>  			    allowBlank: true,
>  			    skipEmptyText: true,





      reply	other threads:[~2022-03-15 14:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-15 13:08 Markus Frank
2022-03-15 14:38 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8be9527f-3d77-4173-9a73-ffab494334b6@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=m.frank@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal