Re: [pbs-devel] possible problem in get_user_run_dir()

Re: [pbs-devel] possible problem in get_user_run_dir()

[Dietmar Maurer]

> Yes, already had an off-list discussion with Fabian about this, the 
> problem here is that /run/proxmox-backup might not exist when this is 
> run, but only root can create it 

Why do you want to use that directory at all? This is meant 
for proxmox-backup server status, not for arbitrary user dada?

Re: [pbs-devel] possible problem in get_user_run_dir()

[Stefan Reiter]

On 06/05/2021 09:29, Dietmar Maurer wrote:
>> Yes, already had an off-list discussion with Fabian about this, the
>> problem here is that /run/proxmox-backup might not exist when this is
>> run, but only root can create it
> 
> Why do you want to use that directory at all? This is meant
> for proxmox-backup server status, not for arbitrary user dada?
> 

It's used here for the VM map for single file restore, so temporary 
data, just scoped per user.

[pbs-devel] possible problem in get_user_run_dir()

[Dietmar Maurer]

The code get_user_run_dir() looks wrong, because a normal user does not have
permissions required for tools::create_run_dir().

Please can you take a look at that? 

--- from src/bin/proxmox_client_tools/mod.rs---

pub fn get_user_run_dir() -> Result<std::path::PathBuf, Error> {
    let uid = nix::unistd::Uid::current();
    let mut path: std::path::PathBuf = buildcfg::PROXMOX_BACKUP_RUN_DIR.into();
    path.push(uid.to_string());
    tools::create_run_dir()?;
    std::fs::create_dir_all(&path)?;
    Ok(path)
}

Re: [pbs-devel] possible problem in get_user_run_dir()

[Stefan Reiter]

On 06/05/2021 08:39, Dietmar Maurer wrote:
> The code get_user_run_dir() looks wrong, because a normal user does not have
> permissions required for tools::create_run_dir().
> 
> Please can you take a look at that?
> 

Yes, already had an off-list discussion with Fabian about this, the 
problem here is that /run/proxmox-backup might not exist when this is 
run, but only root can create it - so far, only root calls it (despite 
the misleading comment), so it works, but for the future, we might want 
to fall back to XDG_USER_RUNTIME_DIR (doesn't always exist though), /tmp 
or some other guaranteed-user-writeable temp location.

> --- from src/bin/proxmox_client_tools/mod.rs---
> 
> pub fn get_user_run_dir() -> Result<std::path::PathBuf, Error> {
>      let uid = nix::unistd::Uid::current();
>      let mut path: std::path::PathBuf = buildcfg::PROXMOX_BACKUP_RUN_DIR.into();
>      path.push(uid.to_string());
>      tools::create_run_dir()?;
>      std::fs::create_dir_all(&path)?;
>      Ok(path)
> }
>