From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup] fix #4722: allow all netmask values for reverse lookup
Date: Wed, 17 May 2023 11:22:13 +0200 [thread overview]
Message-ID: <8a556e53-0a3f-7f61-5a9f-ecc77bed8db2@proxmox.com> (raw)
In-Reply-To: <20230509091513.224508-1-f.gruenbichler@proxmox.com>
Am 09/05/2023 um 11:15 schrieb Fabian Grünbichler:
> the only place this is used (parsing a 'netmask XXX' directive in an interfaces
> file) allows any integer as value both when parsing and when validating, so
> there is no reason to restrict this to only allow string netmasks >=
> 8/255.0.0.0 as far as I can tell..
>
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
> @Dietmar is/was there some reason for this restriction?
makes no sense to me to limit that...
>
> pbs-config/src/network/helper.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
prev parent reply other threads:[~2023-05-17 9:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-09 9:15 [pbs-devel] " Fabian Grünbichler
2023-05-17 9:22 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a556e53-0a3f-7f61-5a9f-ecc77bed8db2@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox