From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup v2] chunk_store: insert_chunk: write chunk again if it is empty on disk
Date: Tue, 10 May 2022 09:47:58 +0200 [thread overview]
Message-ID: <89866f9d-7e08-6f05-bd43-e5c28b1c8935@proxmox.com> (raw)
In-Reply-To: <20220509140906.3488498-1-d.csapak@proxmox.com>
Am 5/9/22 um 16:09 schrieb Dominik Csapak:
> and issue a warning. We can do this, because we know an empty chunk cannot be
> valid, and we (assumedly) have a valid chunk in memory.
>
> Having empty chunks on disk is currently possible when PBS crashes, but the
> rename of the chunk was flushed to disk, when the actual data was not.
>
> If it's not empty but there is a size mismatch, return an error.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> replaces: https://lists.proxmox.com/pipermail/pbs-devel/2022-May/005042.html
>
> changes from v1:
> * warn only on old_size == 0
> * fix old_size/new_size
> * expand commit message
>
> we could do further checks here, but those should be caught by verify.
> the 'real' fix for most of the 0-size chunks will be to either fsync
> the chunks after write/rename, or do a syncfs before the backup ends
>
> pbs-datastore/src/chunk_store.rs | 20 +++++++++++++-------
> 1 file changed, 13 insertions(+), 7 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2022-05-10 7:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 14:09 [pbs-devel] " Dominik Csapak
2022-05-10 7:47 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89866f9d-7e08-6f05-bd43-e5c28b1c8935@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox