public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dietmar Maurer <dietmar@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] pbs-tape: sgutils2: check sense data when status is 'CHECK_CONDITION'
Date: Thu, 21 Apr 2022 09:38:14 +0200	[thread overview]
Message-ID: <88ff3b95-b9ca-5b45-4d90-2c794d54b1b3@proxmox.com> (raw)
In-Reply-To: <20220420133956.1571816-1-d.csapak@proxmox.com>

Thanks! Applied a slightly simplified versions...

On 4/20/22 15:39, Dominik Csapak wrote:
> some raid controllers return a 'transport error' when we expected a
> 'sense error'. it seems the correct way to check the sense data is when
> either the result category is 'SENSE' or when the status i 'CHECK_CONDITION',
> so do that. (similar to how 'sg_raw' returns the errors)
>
> Signed-off-by: Dominik Csapak<d.csapak@proxmox.com>
> ---




      reply	other threads:[~2022-04-21  7:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-20 13:39 Dominik Csapak
2022-04-21  7:38 ` Dietmar Maurer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=88ff3b95-b9ca-5b45-4d90-2c794d54b1b3@proxmox.com \
    --to=dietmar@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal