[pbs-devel] [PATCH v2 proxmox-backup 1/1] PruneJobEdit disallow blank schedule value

[pbs-devel] [PATCH v2 proxmox-backup 1/1] PruneJobEdit disallow blank schedule value

[Stefan Lendl]

The schedule value for prune jobs can not be empty.

Signed-off-by: Stefan Lendl <s.lendl@proxmox.com>
---

Changes v1 -> v2:
* minimal whitespace fix to make it apply

 www/window/PruneJobEdit.js | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/www/window/PruneJobEdit.js b/www/window/PruneJobEdit.js
index b804fdb4..30ec8036 100644
--- a/www/window/PruneJobEdit.js
+++ b/www/window/PruneJobEdit.js
@@ -116,9 +116,8 @@ Ext.define('PBS.window.PruneJobEdit', {
 		fieldLabel: gettext('Prune Schedule'),
 		xtype: 'pbsCalendarEvent',
 		name: 'schedule',
-		emptyText: gettext('none (disabled)'),
+		allowBlank: false,
 		cbind: {
-		    deleteEmpty: '{!isCreate}',
 		    value: '{scheduleValue}',
 		},
 	    },
-- 
2.43.0

Re: [pbs-devel] [PATCH v2 proxmox-backup 1/1] PruneJobEdit disallow blank schedule value

[Gabriel Goller]

Hmm it currently doesn't work, but IMO it should be possible to create a
prune-job without a schedule?
So users can run it manually or temporarily disable a prune-job.

Re: [pbs-devel] [PATCH v2 proxmox-backup 1/1] PruneJobEdit disallow blank schedule value

[Stefan Lendl]

"Gabriel Goller" <g.goller@proxmox.com> writes:

> Hmm it currently doesn't work, but IMO it should be possible to create a
> prune-job without a schedule?
> So users can run it manually or temporarily disable a prune-job.

Yes, I was thinking about that as well.

It's currently possible to manually run a prune job via Content > Prune All

There you have to add the prune keep parameters for each run.
This is not as convenient as if you had an already saved prune job.

I would argue that people only run a manual prune job in very specific
scenarios like when wanting to free up space. In that case, the user
would want to change the keep settings anyway.

Prune jobs have an enable checkbox to (temporarily) disable a prune job.
One can manually start a disabled prune job.

Best regards,
Stefan

Re: [pbs-devel] [PATCH v2 proxmox-backup 1/1] PruneJobEdit disallow blank schedule value

[Gabriel Goller]

> Prune jobs have an enable checkbox to (temporarily) disable a prune job.
> One can manually start a disabled prune job.

Ooof, nevermind, didn't notice that the prune-jobs have a 'enabled'
checkbox.

LGTM then :)

[pbs-devel] applied: [PATCH v2 proxmox-backup 1/1] PruneJobEdit disallow blank schedule value

[Thomas Lamprecht]

Am 07/03/2024 um 14:33 schrieb Stefan Lendl:
> The schedule value for prune jobs can not be empty.
> 
> Signed-off-by: Stefan Lendl <s.lendl@proxmox.com>
> ---
> 
> Changes v1 -> v2:
> * minimal whitespace fix to make it apply
> 
>  www/window/PruneJobEdit.js | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
>

applied, with slight rewording of the commit subject, thanks!