[pbs-devel] [PATCH v2 proxmox-backup] Close #3058: ui: RemoteEdit: Add empty texts

[pbs-devel] [PATCH v2 proxmox-backup] Close #3058: ui: RemoteEdit: Add empty texts

[Dominic Jäger]

Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
---
v1->v2:
Make clear that the emptyTexts are not defaults

 www/window/RemoteEdit.js | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/www/window/RemoteEdit.js b/www/window/RemoteEdit.js
index 56a248e0..6515dce9 100644
--- a/www/window/RemoteEdit.js
+++ b/www/window/RemoteEdit.js
@@ -34,7 +34,8 @@ Ext.define('PBS.window.RemoteEdit', {
 	    {
 		xtype: 'pmxDisplayEditField',
 		name: 'name',
-		fieldLabel: gettext('Remote'),
+		fieldLabel: gettext('Remote ID'),
+		emptyText: 'E.g., new_remote',
 		renderer: Ext.htmlEncode,
 		allowBlank: false,
 		minLength: 4,
@@ -48,7 +49,8 @@ Ext.define('PBS.window.RemoteEdit', {
 		name: 'hostport',
 		submitValue: false,
 		vtype: 'HostPort',
-		fieldLabel: gettext('Host'),
+		fieldLabel: gettext('Remote Address'),
+		emptyText: 'E.g., 192.168.10.10',
 		listeners: {
 		    change: function(field, newvalue) {
 			let host = newvalue;
@@ -94,7 +96,8 @@ Ext.define('PBS.window.RemoteEdit', {
 		xtype: 'proxmoxtextfield',
 		allowBlank: false,
 		name: 'userid',
-		fieldLabel: gettext('Userid'),
+		fieldLabel: gettext('User ID'),
+		emptyText: 'E.g., admin@pbs',
 	    },
 	    {
 		xtype: 'textfield',
@@ -116,6 +119,7 @@ Ext.define('PBS.window.RemoteEdit', {
 		    deleteEmpty: '{!isCreate}',
 		},
 		fieldLabel: gettext('Fingerprint'),
+		emptyText: 'Server certificate SHA-256 fingerprint, required for self-signed certificates',
 	    },
 	    {
 		xtype: 'proxmoxtextfield',
-- 
2.20.1

Re: [pbs-devel] [PATCH v2 proxmox-backup] Close #3058: ui: RemoteEdit: Add empty texts

[Thomas Lamprecht]

On 07.10.20 11:53, Dominic Jäger wrote:
> Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
> ---
> v1->v2:
> Make clear that the emptyTexts are not defaults
> 
>  www/window/RemoteEdit.js | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/www/window/RemoteEdit.js b/www/window/RemoteEdit.js
> index 56a248e0..6515dce9 100644
> --- a/www/window/RemoteEdit.js
> +++ b/www/window/RemoteEdit.js
> @@ -34,7 +34,8 @@ Ext.define('PBS.window.RemoteEdit', {
>  	    {
>  		xtype: 'pmxDisplayEditField',
>  		name: 'name',
> -		fieldLabel: gettext('Remote'),
> +		fieldLabel: gettext('Remote ID'),
> +		emptyText: 'E.g., new_remote',

I still would rather have something along the lines of:
gettext('An unique name to identify this remote.')

and that rather as tooltip here, for free choosable names that
just feels weird else.

>  		renderer: Ext.htmlEncode,
>  		allowBlank: false,
>  		minLength: 4,
> @@ -48,7 +49,8 @@ Ext.define('PBS.window.RemoteEdit', {
>  		name: 'hostport',
>  		submitValue: false,
>  		vtype: 'HostPort',
> -		fieldLabel: gettext('Host'),
> +		fieldLabel: gettext('Remote Address'),
> +		emptyText: 'E.g., 192.168.10.10',

I though you wanted to avoid E.g. due to our writing guide? :)

Could be instead done as tooltip with a more helping hint:
gettext('The DNS or IP address of the remote, optionally with a port.')

>  		listeners: {
>  		    change: function(field, newvalue) {
>  			let host = newvalue;
> @@ -94,7 +96,8 @@ Ext.define('PBS.window.RemoteEdit', {
>  		xtype: 'proxmoxtextfield',
>  		allowBlank: false,
>  		name: 'userid',
> -		fieldLabel: gettext('Userid'),
> +		fieldLabel: gettext('User ID'),
> +		emptyText: 'E.g., admin@pbs',

s/E.g./For example/

besides that: this is OK, IMO, User ID is pretty fixed in format (nothing
optional), so a single example shows the user that the @realm part is wanted.

>  	    },
>  	    {
>  		xtype: 'textfield',
> @@ -116,6 +119,7 @@ Ext.define('PBS.window.RemoteEdit', {
>  		    deleteEmpty: '{!isCreate}',
>  		},
>  		fieldLabel: gettext('Fingerprint'),
> +		emptyText: 'Server certificate SHA-256 fingerprint, required for self-signed certificates',
>  	    },
>  	    {
>  		xtype: 'proxmoxtextfield',
>