From: Christian Ebner <c.ebner@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Gabriel Goller <g.goller@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] pxar-bin: remove `log` dependency, use `tracing` directly
Date: Wed, 4 Sep 2024 14:31:06 +0200 [thread overview]
Message-ID: <874bad1a-26e2-4f2a-a3d5-2e8ed6177f2f@proxmox.com> (raw)
In-Reply-To: <776bce92-9199-4686-b171-c6b579c4d422@proxmox.com>
On 9/4/24 10:06, Christian Ebner wrote:
> small nits inline
>
> As you already discussed with Wolfgang in the other thread, any user
> facing output not intended for debugging, e.g. the output of the `pxar
> list` might be better displayed by writing to stdout using a `println`
> instead.
>
> Tested by listing and extracting a pxar archive, with and without the
> `PXAR_LOG=debug` environment variable set.
>
> Other than that, please consider this and the patch to `proxmox-log`:
>
> Tested-by: Christian Ebner <c.ebner@proxmox.com>
> Reviewed-by: Christian Ebner <c.ebner@proxmox.com>
>
Also, this needs a `cargo fmt` to correctly sort the entities in the
proxmox_log use statement.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-09-04 12:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 12:38 [pbs-devel] [PATCH proxmox] log: write to stderr when using init_cli_logger, export tracing::Level Gabriel Goller
2024-09-03 12:38 ` [pbs-devel] [PATCH proxmox-backup] pxar-bin: remove `log` dependency, use `tracing` directly Gabriel Goller
2024-09-04 8:06 ` Christian Ebner
2024-09-04 12:31 ` Christian Ebner [this message]
2024-09-04 13:27 ` Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874bad1a-26e2-4f2a-a3d5-2e8ed6177f2f@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox