From: Dominik Csapak <d.csapak@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Gabriel Goller <g.goller@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] fix: ui: spinner position
Date: Fri, 13 Oct 2023 15:04:54 +0200 [thread overview]
Message-ID: <87356f09-673e-4ae8-ba0a-9cedc30e5572@proxmox.com> (raw)
In-Reply-To: <92df7c1a-2691-4971-93a8-22bc9d260ed8@proxmox.com>
On 10/13/23 14:38, Thomas Lamprecht wrote:
> Am 12/10/2023 um 14:34 schrieb Dominik Csapak:
>> On 10/12/23 13:49, Gabriel Goller wrote:
>>> On 10/12/23 11:28, Dominik Csapak wrote:
>>>> *if* we want to change this, we either would have to adapt pve/pmg as well,
>>>> or refactor the class into the widget-toolkit (idk if there are some differences
>>>> across products, though it shouldn't be), because we also use that for the task
>>>> and job status list (e.g. replication)
>>>
>>> I looked at them briefly and they have a few things in common, but imo
>>> it's not worth the hassle combining them. We wouldn't **need** this in
>>> pve/pmg but I could still submit a patch... let me know.
>>>
>>>>
>>
>> Depends on your definition of **need**. If we don't do this,
>> it would look differently e.g. for the task list in pve/pmg vs pbs
>> and we want to have the UI consistent across products
>> (except if there is a good reason to diverge) so for me it is
>> important to stay consistent here.
>>
>> @Thomas any opinion on this?
>
> I find Gabriel has a point, it looks odd as is, and aligning it right
> makes it better fit in with other states like "OK" or "Error: ..".)
fine with me then
>
> Having something like "Running" as text here would be nice, but we
> cannot just use a `.x-grid-row-loading:after { content: 'Running' }`
> as that misses translations.
>
> One option would be to avoid ExtJS CSS here and use font-awesome like
> "fa fa-fw fa-circle-o-notch fa-spin", the only disadvantage from that
> is that we lose the site-wide synced animation that the currently used
> GIF provides, can be worked around but IIRC there's nothing native
> available for doing so.
we could also create our own class that uses the gif as a background image, or
simply embed the gif directly? then we'd keep the image and could still
add a translated text
>
> For now the adapted CSS would be an OK stop-gap, IIRC we only use such
> grid loading classes for such scheduled-job grids. Adding it to PVE
> (isn't there even anything besides replication using that?) would be
> good too though. IMO no need for widget toolkit, I'd keep this contained
> for now.
we use that for running tasks and replication, and the class
'x-grid-row-loading' is the same for pve/pmg/pbs (so i thought it might
warrant to have it in widget toolkit, so that we can remove it from the
individual projects' css files)
next prev parent reply other threads:[~2023-10-13 13:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 14:20 Gabriel Goller
2023-10-11 11:06 ` Gabriel Goller
2023-10-12 9:28 ` Dominik Csapak
2023-10-12 11:49 ` Gabriel Goller
2023-10-12 12:34 ` Dominik Csapak
2023-10-12 12:40 ` Gabriel Goller
2023-10-13 12:38 ` Thomas Lamprecht
2023-10-13 13:04 ` Dominik Csapak [this message]
2023-10-16 9:51 ` Gabriel Goller
2023-10-16 10:04 ` Thomas Lamprecht
2023-10-16 11:57 ` Gabriel Goller
2023-10-16 12:41 ` Gabriel Goller
2023-10-18 10:09 ` Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87356f09-673e-4ae8-ba0a-9cedc30e5572@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox