From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup] server/prune_job: fix locking during prune jobs
Date: Wed, 2 Jun 2021 17:09:47 +0200 [thread overview]
Message-ID: <86c9f699-e363-f0d2-7ba1-884d7c458e2a@proxmox.com> (raw)
In-Reply-To: <20210602135425.27990-1-d.csapak@proxmox.com>
On 02.06.21 15:54, Dominik Csapak wrote:
> removing the backup dir must acquire the snapshot lock, else it can
> happen that we remove a snapshot while it is being restored
> or backed up to tape
>
> the original commit that adds the force flag
> (c9756b40d1b33c573216f7c8eba209200c1d9bd5)
> mentions that the prune checks itself if the snapshot is in use,
> but i could not find such code, so simply set force to false
argh...
> to avoid failing and aborting the prune job, warn if it could not
> and continue
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> src/server/prune_job.rs | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
>
applied, thanks!
prev parent reply other threads:[~2021-06-02 15:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 13:54 [pbs-devel] " Dominik Csapak
2021-06-02 15:09 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86c9f699-e363-f0d2-7ba1-884d7c458e2a@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox