public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Philipp Hufnagl <p.hufnagl@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup v7 3/4] docs: document new include/exclude paramenter
Date: Mon, 22 Jan 2024 16:13:02 +0100	[thread overview]
Message-ID: <8635a11b-a4bb-453d-ab2b-70e778f4509b@proxmox.com> (raw)
In-Reply-To: <20240102110655.155329-4-p.hufnagl@proxmox.com>

Am 02/01/2024 um 12:06 schrieb Philipp Hufnagl:
> Adding the newly introduced optional include/exclude parameter to the
> PBS documentation.
> 
> Signed-off-by: Philipp Hufnagl <p.hufnagl@proxmox.com>
> ---
>  docs/managing-remotes.rst | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/docs/managing-remotes.rst b/docs/managing-remotes.rst
> index f8dcff6d..10ca1084 100644
> --- a/docs/managing-remotes.rst
> +++ b/docs/managing-remotes.rst
> @@ -116,6 +116,19 @@ of the specified criteria are synced. The available criteria are:
>  The same filter is applied to local groups, for handling of the
>  ``remove-vanished`` option.
>  
> +A ``group-filter`` can be inverted by adding ``exclude:`` to its beginning.
> +
> +* Regular expression example, excluding the match:
> +    .. code-block:: console
> +
> +     # proxmox-backup-manager sync-job update ID --group-filter exclude:regex:'^vm/1\d{2,3}$'
> +
> +For mixing include and exclude filter, following rules apply:
> +
> + - no filters: all backup groups
> + - include: only those matching the include filters
> + - exclude: all but those matching the exclude filters
> + - both: those matching the include filters, but without those matching the exclude filters

FYI: missing a newline here, that broke the admonition node below as sphinx/rst
interprets this as continuation of the list.

Fixed already in git with a follow up, just noting to avoid repetition of 
this tiny mistake, restructured text is (sadly) like python really whitespace
sensitive..

>  .. note:: The ``protected`` flag of remote backup snapshots will not be synced.
>  
>  Namespace Support





  reply	other threads:[~2024-01-22 15:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-02 11:06 [pbs-devel] [PATCH proxmox-backup v7 0/4] fix #4315: datastore: Exclude entries from sync Philipp Hufnagl
2024-01-02 11:06 ` [pbs-devel] [PATCH proxmox-backup v7 1/4] fix #4315: jobs: modify GroupFilter so include/exclude is tracked Philipp Hufnagl
2024-01-02 11:06 ` [pbs-devel] [PATCH proxmox-backup v7 2/4] ui: Show if Filter includes or excludes Philipp Hufnagl
2024-01-02 11:06 ` [pbs-devel] [PATCH proxmox-backup v7 3/4] docs: document new include/exclude paramenter Philipp Hufnagl
2024-01-22 15:13   ` Thomas Lamprecht [this message]
2024-01-02 11:06 ` [pbs-devel] [PATCH proxmox-backup v7 4/4] tests: check if include/exclude behavior works correctly Philipp Hufnagl
2024-01-02 13:33 ` [pbs-devel] [PATCH proxmox-backup v7 0/4] fix #4315: datastore: Exclude entries from sync Lukas Wagner
2024-01-10  9:14 ` [pbs-devel] applied-series: " Wolfgang Bumiller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8635a11b-a4bb-453d-ab2b-70e778f4509b@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=p.hufnagl@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal