From: Dominik Csapak <d.csapak@proxmox.com>
To: Gabriel Goller <g.goller@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] fix: ui: spinner position
Date: Thu, 12 Oct 2023 14:34:36 +0200 [thread overview]
Message-ID: <83b3341d-9b14-4c0d-9265-65fb9d95dcfe@proxmox.com> (raw)
In-Reply-To: <9912014b-0ad8-4cf8-9ce7-8b46a553b55b@proxmox.com>
On 10/12/23 13:49, Gabriel Goller wrote:
> On 10/12/23 11:28, Dominik Csapak wrote:
>> *if* we want to change this, we either would have to adapt pve/pmg as well,
>> or refactor the class into the widget-toolkit (idk if there are some differences
>> across products, though it shouldn't be), because we also use that for the task
>> and job status list (e.g. replication)
>
> I looked at them briefly and they have a few things in common, but imo
> it's not worth the hassle combining them. We wouldn't **need** this in
> pve/pmg but I could still submit a patch... let me know.
>
>>
Depends on your definition of **need**. If we don't do this,
it would look differently e.g. for the task list in pve/pmg vs pbs
and we want to have the UI consistent across products
(except if there is a good reason to diverge) so for me it is
important to stay consistent here.
@Thomas any opinion on this?
next prev parent reply other threads:[~2023-10-12 12:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 14:20 Gabriel Goller
2023-10-11 11:06 ` Gabriel Goller
2023-10-12 9:28 ` Dominik Csapak
2023-10-12 11:49 ` Gabriel Goller
2023-10-12 12:34 ` Dominik Csapak [this message]
2023-10-12 12:40 ` Gabriel Goller
2023-10-13 12:38 ` Thomas Lamprecht
2023-10-13 13:04 ` Dominik Csapak
2023-10-16 9:51 ` Gabriel Goller
2023-10-16 10:04 ` Thomas Lamprecht
2023-10-16 11:57 ` Gabriel Goller
2023-10-16 12:41 ` Gabriel Goller
2023-10-18 10:09 ` Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83b3341d-9b14-4c0d-9265-65fb9d95dcfe@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox