[pbs-devel] applied: [PATCH v2 proxmox-backup] ui: sync job: fix source group filters based on sync direction

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 25.11.24 um 12:03 schrieb Christian Ebner:
> Fix switching the source for group filters based on the sync jobs
> sync direction.
> 
> The helper to set the local namespace for the group filers was
> introduced in commit 43a92c8c ("ui: group filter: allow to set
> namespace for local datastore"), but never used because lost during
> subsequent iterations of reworking the patch series.
> 
> The switching is corrected by:
> - correctly initializing the local store and namespace for the group
>   filer of sync jobs in push direction in the controller init, if a
>   datastore is set.
> - fixing an incorrect check for the sync direction in the remote
>   datastore selector change listener.
> - conditionally switching namespace to be set for the group filter in
>   the remote and local namespace selector change listeners.
> - conditionally switching datastore to be set for the group filter in
>   the local datastore selector change listener.
> 
> Reported-by: Lukas Wagner <l.wagner@proxmox.com>
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
> changes since version 1 (thanks @Dominik for catching the issues):
> - only init group filters if there is a datastore given
> - also switch group filters datastore when switching local datastore
> - removed unneeded setLocalDatastore, as setLocalNamespace sets
>   datastore and namespace
> - fixed eslint issues
> - updated commit message
> 
>  www/window/SyncJobEdit.js | 31 +++++++++++++++++++++++++++++--
>  1 file changed, 29 insertions(+), 2 deletions(-)
> 
>

applied, with Dominik's R-b and T-b, thanks!


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel