[pbs-devel] [PATCH proxmox] fix #5249: apt: allow parsing Packages without Priority field

[pbs-devel] [PATCH proxmox] fix #5249: apt: allow parsing Packages without Priority field

[Fabian Grünbichler]

it seems there are repositories out there that don't (always) include it, and
while it is required for the .deb packages themselves in Debian, the repository
"spec" doesn't make it mandatory.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---

Notes:
    technically a breaking change, but we don't use the priority field anywhere..
    requires a bump+rebuild of POM to take effect

 proxmox-apt/src/deb822/packages_file.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/proxmox-apt/src/deb822/packages_file.rs b/proxmox-apt/src/deb822/packages_file.rs
index b3c84b06..aec0a926 100644
--- a/proxmox-apt/src/deb822/packages_file.rs
+++ b/proxmox-apt/src/deb822/packages_file.rs
@@ -14,7 +14,7 @@ pub struct PackagesFileRaw {
     pub source: Option<String>,
     pub version: String,
     pub section: Option<String>,
-    pub priority: String,
+    pub priority: Option<String>,
     pub architecture: String,
     pub essential: Option<String>,
     pub depends: Option<String>,
-- 
2.39.2

Re: [pbs-devel] [PATCH proxmox] fix #5249: apt: allow parsing Packages without Priority field

[Fabian Grünbichler]

ping

On March 14, 2024 11:26 am, Fabian Grünbichler wrote:
> it seems there are repositories out there that don't (always) include it, and
> while it is required for the .deb packages themselves in Debian, the repository
> "spec" doesn't make it mandatory.
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
> 
> Notes:
>     technically a breaking change, but we don't use the priority field anywhere..
>     requires a bump+rebuild of POM to take effect
> 
>  proxmox-apt/src/deb822/packages_file.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/proxmox-apt/src/deb822/packages_file.rs b/proxmox-apt/src/deb822/packages_file.rs
> index b3c84b06..aec0a926 100644
> --- a/proxmox-apt/src/deb822/packages_file.rs
> +++ b/proxmox-apt/src/deb822/packages_file.rs
> @@ -14,7 +14,7 @@ pub struct PackagesFileRaw {
>      pub source: Option<String>,
>      pub version: String,
>      pub section: Option<String>,
> -    pub priority: String,
> +    pub priority: Option<String>,
>      pub architecture: String,
>      pub essential: Option<String>,
>      pub depends: Option<String>,
> -- 
> 2.39.2
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] applied: [PATCH proxmox] fix #5249: apt: allow parsing Packages without Priority field

[Thomas Lamprecht]

Am 14/03/2024 um 11:26 schrieb Fabian Grünbichler:
> it seems there are repositories out there that don't (always) include it, and
> while it is required for the .deb packages themselves in Debian, the repository
> "spec" doesn't make it mandatory.
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
> 
> Notes:
>     technically a breaking change, but we don't use the priority field anywhere..
>     requires a bump+rebuild of POM to take effect
> 
>  proxmox-apt/src/deb822/packages_file.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, thanks!


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel