public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pbs-devel] [PATCH backup v2 0/2] fix #5946: disks: wipe: ensure GPT header backup is wiped
@ 2025-02-11 16:26 Filip Schauer
  2025-02-11 16:26 ` [pbs-devel] [PATCH backup v2 1/2] " Filip Schauer
  2025-02-11 16:26 ` [pbs-devel] [PATCH backup v2 2/2] disks: wipe: only zero out the first 1 MiB Filip Schauer
  0 siblings, 2 replies; 8+ messages in thread
From: Filip Schauer @ 2025-02-11 16:26 UTC (permalink / raw)
  To: pbs-devel

When wiping a block device with a GUID partition table, the header
backup might get left behind at the end of the disk. This commit also
wipes the last 4096 bytes of the disk, making sure that a GPT header
backup is erased, even from disks with 4k sector sizes.

Also lower the number of bytes that is zeroed out at the start of the
disk from 200 MiB to 1 MiB.

Changed since v1:
* Use `std::os::unix::fs::FileExt::write_all_at` instead of calling `dd`
* only zero out the first 1 MiB

Filip Schauer (2):
  fix #5946: disks: wipe: ensure GPT header backup is wiped
  disks: wipe: only zero out the first 1 MiB

 src/tools/disks/mod.rs | 49 +++++++++++++++++++++++-------------------
 1 file changed, 27 insertions(+), 22 deletions(-)

-- 
2.39.5



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2025-02-12 13:44 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-02-11 16:26 [pbs-devel] [PATCH backup v2 0/2] fix #5946: disks: wipe: ensure GPT header backup is wiped Filip Schauer
2025-02-11 16:26 ` [pbs-devel] [PATCH backup v2 1/2] " Filip Schauer
2025-02-11 18:39   ` Thomas Lamprecht
2025-02-12 11:01     ` Filip Schauer
2025-02-11 16:26 ` [pbs-devel] [PATCH backup v2 2/2] disks: wipe: only zero out the first 1 MiB Filip Schauer
2025-02-11 18:42   ` Thomas Lamprecht
2025-02-12 10:24     ` Filip Schauer
2025-02-12 13:44       ` Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal