From: Dietmar Maurer <dietmar@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup 1/2] ui: datastore/Content: reload in activate listener
Date: Mon, 4 Oct 2021 10:29:50 +0200 [thread overview]
Message-ID: <8105e11b-b879-24c4-0d6b-ebb5d939dc0a@proxmox.com> (raw)
In-Reply-To: <20211001095655.2678928-1-d.csapak@proxmox.com>
applied both patches
On 10/1/21 11:56 AM, Dominik Csapak wrote:
> when we trigger the first load before the panel was fully created,
> there was no load mask for it (but the snapshots would "pop in" on load)
>
> move the first reload into the 'activate' listener. this will be called
> the every time a user opens the content tab of a datastore, so guard
> it by a 'firstLoad' bool.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/datastore/Content.js | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/www/datastore/Content.js b/www/datastore/Content.js
> index 57693785..ddc923fd 100644
> --- a/www/datastore/Content.js
> +++ b/www/datastore/Content.js
> @@ -73,7 +73,6 @@ Ext.define('PBS.DataStoreContent', {
> 'backup-time',
> ]);
> Proxmox.Utils.monStoreErrors(view, this.store);
> - this.reload(); // initial load
> },
>
> reload: function() {
> @@ -625,6 +624,17 @@ Ext.define('PBS.DataStoreContent', {
> },
> },
>
> + listeners: {
> + activate: function() {
> + let me = this;
> + // only load on first activate to not load every tab switch
> + if (!me.firstLoad) {
> + me.getController().reload();
> + me.firstLoad = true;
> + }
> + },
> + },
> +
> viewConfig: {
> getRowClass: function(record, index) {
> let verify = record.get('verification');
prev parent reply other threads:[~2021-10-04 8:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 9:56 [pbs-devel] " Dominik Csapak
2021-10-01 9:56 ` [pbs-devel] [PATCH proxmox-backup 2/2] ui: datastore/Content: add empty text for no snapshots Dominik Csapak
2021-10-04 8:29 ` Dietmar Maurer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8105e11b-b879-24c4-0d6b-ebb5d939dc0a@proxmox.com \
--to=dietmar@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox