From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox] build: use weak and namespaced features
Date: Fri, 26 Aug 2022 13:40:59 +0200 [thread overview]
Message-ID: <80d91d02-36b9-4420-6bf5-73e4031d030d@proxmox.com> (raw)
In-Reply-To: <20220822092404.323172-1-f.gruenbichler@proxmox.com>
Am 22/08/2022 um 11:24 schrieb Fabian Grünbichler:
> to reduce the creep of optional dependencies being exposed as features.
>
> this requires cargo 0.63 (and debcargo built against at least that
> version), but greatly reduces the number of binary packages and provides
> generated, while still allowing sensible selection of optional
> dependencies via the explicit feature meant for pulling them in.
>
> diff stat for running `make deb` after this change:
> proxmox-http/debian/control | 226 ++++--------------------------------
> proxmox-router/debian/control | 74 +-----------
> proxmox-schema/debian/control | 53 ++-------
> proxmox-subscription/debian/control | 17 +--
> proxmox-sys/debian/control | 51 +++-----
> proxmox-tfa/debian/control | 110 ++----------------
> 6 files changed, 72 insertions(+), 459 deletions(-)
>
> the 'dep:' prefix marks something on the RHS inside the features section
> as dependency, it's only allowed if the string after it is an optional
> dependency an no explicit feature of the same name exists. if all
> pointers to the optional dependency in the features section are marked
> as such, the optional dependency itself will not be exposed as a feature
> (either on the cargo or debian/control level).
>
> the '?' suffix marks dependencies as "weak", which only enables the
> optional dependency + its feature(s) if the optional dependency itself
> is also enabled. it has no effect on d/control since such a relationship
> is not encodable in Debian package relations, but it does affect cargo
> dependency resolution and allows skipping the build of unneeded optional
> dependencies in some cases.
>
> with no packages/crates depending on the no longer exposed automatically
> generated features/packages, so these are safe to remove even though
> it's technically a breaking change.
>
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
> sent as patch to wait for cargo 0.63 regressions before applying
>
> proxmox-http/Cargo.toml | 26 ++++++++++++++------------
> proxmox-router/Cargo.toml | 2 +-
> proxmox-schema/Cargo.toml | 4 ++--
> proxmox-subscription/Cargo.toml | 2 +-
> proxmox-sys/Cargo.toml | 4 ++--
> proxmox-tfa/Cargo.toml | 6 +++---
> 6 files changed, 23 insertions(+), 21 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2022-08-26 11:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 9:24 [pbs-devel] " Fabian Grünbichler
2022-08-26 11:40 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80d91d02-36b9-4420-6bf5-73e4031d030d@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox