From: Gabriel Goller <g.goller@proxmox.com>
To: Wolfgang Bumiller <w.bumiller@proxmox.com>
Cc: Lukas Wagner <l.wagner@proxmox.com>, pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH proxmox v2 1/4] log: rename/move init functions
Date: Tue, 18 Feb 2025 17:15:39 +0100 [thread overview]
Message-ID: <7vemof4ooe34hbmbaojmumbb5qnwzpmy443vd7r2fudjlxc7vk@ruloksfxwu6m> (raw)
In-Reply-To: <hjrmzxu77qslue6xrezepccddwkphyvvkgodzm22mfxyze3hhv@mjk5q7ge63bg>
>> > > * pbs tape pmt
>> > > * pbs tape pmtx
>> > > * pbs client
>> > > * pbs pxar
>> > > * pbs proxmox-backup-debug
>> > > * pbs proxmox-backup-manager
>> > > * pbs proxmox-backup-tape
>> > > * pbs sg-tape-cmd
>> >
>> > ^ IIRC all of these are CLI tools and should therefore all be case (2) -
>> > although I don't know about how the tape stuff works.
>> > If they do anything else, it would be good to know why and have this
>> > documented either in proxmox-log or in their logging-init functions.
>>
>> All except the proxmox-backup-manager as far as I can see, because that
>> one starts pbs tasks directly.
>>
>> > > * pbs proxmox-daily-update
>> >
>> > The 'daily-update' may be a special case and could use the journal
>> > directly, but may as well be stderr->journald via its `.service`.
>> > But, yeah, obviously it would make actual tracing/debugging easier with
>> > a proper journald-logger here. So another user of case (1).
>>
>> Agree.
Nevermind actually, proxmox-daily-update calls a workertask, so we need
journald and tasklog layer, similar to the daemon's setup.
Sent a new series: https://lore.proxmox.com/pve-devel/20250218161311.558674-1-g.goller@proxmox.com/
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-02-18 16:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-09 10:46 [pbs-devel] [PATCH proxmox{, -backup, -perl-rs} v2 0/4] Rename/Move logging init helper Gabriel Goller
2024-12-09 10:46 ` [pbs-devel] [PATCH proxmox v2 1/4] log: rename/move init functions Gabriel Goller
2025-02-10 14:37 ` Wolfgang Bumiller
2025-02-10 16:42 ` Gabriel Goller
2025-02-11 9:22 ` Wolfgang Bumiller
2025-02-11 9:28 ` Wolfgang Bumiller
2025-02-17 13:08 ` Gabriel Goller
2025-02-17 13:38 ` Wolfgang Bumiller
2025-02-17 14:12 ` Gabriel Goller
2025-02-17 14:51 ` Wolfgang Bumiller
2025-02-17 15:21 ` Gabriel Goller
2025-02-18 10:06 ` Wolfgang Bumiller
2025-02-18 16:15 ` Gabriel Goller [this message]
2025-02-11 9:31 ` Gabriel Goller
2024-12-09 10:46 ` [pbs-devel] [PATCH proxmox v2 2/4] log: add logger for perlmod crates Gabriel Goller
2024-12-09 10:46 ` [pbs-devel] [PATCH proxmox-backup v2 3/4] log: use new init functions Gabriel Goller
2024-12-09 10:46 ` [pbs-devel] [PATCH proxmox-perl-rs v2 4/4] log: use new init function, print to stderr and journald Gabriel Goller
2025-01-09 10:09 ` [pbs-devel] [PATCH proxmox{, -backup, -perl-rs} v2 0/4] Rename/Move logging init helper Lukas Wagner
2025-01-14 8:43 ` Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vemof4ooe34hbmbaojmumbb5qnwzpmy443vd7r2fudjlxc7vk@ruloksfxwu6m \
--to=g.goller@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal