Re: [pbs-devel] [PATCH proxmox-backup 2/4] api2/confif/datastore: add create datastore api call in a worker

[Dietmar Maurer <dietmar@proxmox.com>]

On 6/1/21 4:33 PM, Thomas Lamprecht wrote:
> On 01.06.21 14:13, Dominik Csapak wrote:
>> so that longer running creates (e.g. a slow storage), does not
>> run in a timeout and we can follow its creation
>>
> In PVE we did not treated a changed in return value as breaking change, I mean not
> in general, as it is a bit depended on what was returned previously, but we didn't
> considered it if there was nothing returned before.
>
> I'd rather do one either:
> * wait for the 2.0 branch and just move over the existing one to always return a task
>    UPID, least amount of work and as 2.0 is not that far away it would be quite reasonable
>    IMO
>
> * just switch now, the manager CLI can be adapted in one go, and the gui can switch too
>    as both are shipped by the exact same binary package, also OK IMO, but others may be
>    have objections (?)

I prefer above option (just switch now).

>
> * return the upid as option and add an opt-in switch for the in worker, and if not set
>    then poll in sync for it being finished, could be removed with 2.0 or just the default
>    switched
>
> mostly as I'd like to avoid duplicate entries of endpoints where we plan to use the new
> one only anyway (as quite some metadata IO is involved it's effectively the only sensible
> one).
>
>