From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Christian Ebner <c.ebner@proxmox.com>
Subject: [pbs-devel] applied-series: [PATCH proxmox-backup 0/4] use same config section type for all sync jobs
Date: Tue, 26 Nov 2024 16:04:08 +0100 [thread overview]
Message-ID: <7e6120e1-3b9b-424b-92d2-67a747f75009@proxmox.com> (raw)
In-Reply-To: <20241125174012.678523-1-c.ebner@proxmox.com>
Am 25.11.24 um 18:40 schrieb Christian Ebner:
> This patch series drops the `sync-push` config section type in favor of
> using the same `sync` for both, sync jobs in push and pull direction.
> Instead, encode the sync direction as optional parameter in the sync job
> config, defaulting to sync in pull direction. This reduces complexity by
> allowing to drop the optional parameter for most function calls.
> For api methods, the default remains to only show sync directions in
> pull direction, if no ListSyncDirection::All is passed, or the direction
> explicitly selected. This allows to default to show both directions in
> future Proxmox Backup Server version.
>
> This patch series depends on Dominik's patch series found here:
> https://lore.proxmox.com/pbs-devel/377618fd-0ea9-46ba-9aec-a47387eca50d@proxmox.com/T
>
> Christian Ebner (4):
> config: sync: use same config section type `sync` for push and pull
> api: admin/config: introduce sync direction as job config parameter
> bin: show direction in sync job list output
> api types: drop unused config type helpers for sync direction
>
> pbs-api-types/src/jobs.rs | 25 ++--
> pbs-config/src/sync.rs | 17 +--
> src/api2/admin/sync.rs | 18 +--
> src/api2/config/datastore.rs | 16 +--
> src/api2/config/notifications/mod.rs | 19 ++--
> src/api2/config/sync.rs | 151 ++++++++-----------------
> src/bin/proxmox-backup-proxy.rs | 22 +---
> src/bin/proxmox_backup_manager/sync.rs | 6 +-
> src/server/sync.rs | 2 +-
> 9 files changed, 88 insertions(+), 188 deletions(-)
>
applied series with both Fabian's and Dominik's follow-ups and from the latter
also his review trailers, thanks!
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2024-11-26 15:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-25 17:40 [pbs-devel] " Christian Ebner
2024-11-25 17:40 ` [pbs-devel] [PATCH proxmox-backup 1/4] config: sync: use same config section type `sync` for push and pull Christian Ebner
2024-11-25 17:40 ` [pbs-devel] [PATCH proxmox-backup 2/4] api: admin/config: introduce sync direction as job config parameter Christian Ebner
2024-11-25 17:40 ` [pbs-devel] [PATCH proxmox-backup 3/4] bin: show direction in sync job list output Christian Ebner
2024-11-25 17:40 ` [pbs-devel] [PATCH proxmox-backup 4/4] api types: drop unused config type helpers for sync direction Christian Ebner
2024-11-26 9:20 ` [pbs-devel] [PATCH proxmox-backup] (List)SyncDirection: extract match check into impl fn Fabian Grünbichler
2024-11-26 9:21 ` [pbs-devel] [PATCH proxmox-backup 0/4] use same config section type for all sync jobs Fabian Grünbichler
2024-11-26 14:47 ` [pbs-devel] [PATCH proxmox-backup] sync jobs: remove superfluous direction property Dominik Csapak
2024-11-26 14:50 ` [pbs-devel] [PATCH proxmox-backup 0/4] use same config section type for all sync jobs Dominik Csapak
2024-11-26 15:04 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e6120e1-3b9b-424b-92d2-67a747f75009@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox