Re: [pbs-devel] [PATCH proxmox-backup v4 2/2] close #4723: api: added endpoint for gc status

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 27/09/2023 um 15:06 schrieb Gabriel Goller:
> update v4:
>  - separate commits for ui/api

No thorough review, I'm afraid, but two things I noticed when skimming
this:

1. Please order patches such that the dependency order is correct.
Here you added the UI using a new API endpoint before adding said
endpoint.

It's easier to review, and less error-prone, e.g., if there are patches
that seem like they could be applied already, while some other parts of
such a patch series might still need rework.

I hope I (or maybe someone else) can give this a more thorough review.
If the order and the endpoint name (see below) will stay the only two
issues, there's no hard need for a v3, I can also fix those up on
applying.

>  - cleaned up code
>  - show 'next scheduled run', when no gc has ever been run


> @@ -2265,6 +2383,10 @@ const DATASTORE_INFO_SUBDIRS: SubdirMap = &[
>              .get(&API_METHOD_GARBAGE_COLLECTION_STATUS)
>              .post(&API_METHOD_START_GARBAGE_COLLECTION),
>      ),
> +    (
> +        "gc_info",

2. Please use kepbab-case, not snake_case, for things part of the public
API, like the URL here (but also parameters, which you already handle
correctly).