From: Christian Ebner <c.ebner@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Hannes Laimer <h.laimer@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup v3 7/7] ui: add task title for triggering sync jobs
Date: Fri, 4 Jul 2025 14:42:16 +0200 [thread overview]
Message-ID: <7c820f33-ff8a-4d19-b808-61a9343b0a75@proxmox.com> (raw)
In-Reply-To: <20250604123054.87007-8-h.laimer@proxmox.com>
On 6/4/25 14:30, Hannes Laimer wrote:
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
> www/Utils.js | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/www/Utils.js b/www/Utils.js
> index 9dcde694..eb494301 100644
> --- a/www/Utils.js
> +++ b/www/Utils.js
> @@ -422,6 +422,7 @@ Ext.define('PBS.Utils', {
> prunejob: (type, id) => PBS.Utils.render_prune_job_worker_id(id, gettext('Prune Job')),
> reader: (type, id) => PBS.Utils.render_datastore_worker_id(id, gettext('Read Objects')),
> 'rewind-media': [gettext('Drive'), gettext('Rewind Media')],
> + 'mount-sync-jobs': [gettext('Datastore'), gettext('trigger sync jobs')],
nit: while not an issue, the text here is a bit unfitting, as this job
will complete *after* all the sync jobs it's executing.
Therefore, this shows up in the task log after the sync jobs entries. So
maybe instead of `trigger sync jobs`, this could state `sync jobs
handler triggered by mount`... or something even better fitting...
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-07-04 12:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-04 12:30 [pbs-devel] [PATCH-SERIES proxmox/proxmox-backup v3 0/7] trigger sync jobs on mount Hannes Laimer
2025-06-04 12:30 ` [pbs-devel] [PATCH proxmox v3 1/7] pbs-api-types: add run-on-mount flag to SyncJobConfig Hannes Laimer
2025-06-04 12:30 ` [pbs-devel] [PATCH proxmox-backup v3 2/7] api: config: sync: update run-on-mount correctly Hannes Laimer
2025-06-04 12:30 ` [pbs-devel] [PATCH proxmox-backup v3 3/7] api: admin: run configured sync jobs when a datastore is mounted Hannes Laimer
2025-07-04 11:30 ` Christian Ebner
2025-07-16 12:14 ` Hannes Laimer
2025-06-04 12:30 ` [pbs-devel] [PATCH proxmox-backup v3 4/7] api: admin: trigger sync jobs only on datastore mount Hannes Laimer
2025-06-04 12:30 ` [pbs-devel] [PATCH proxmox-backup v3 5/7] bin: manager: run uuid_mount/mount tasks on the proxy Hannes Laimer
2025-06-04 12:30 ` [pbs-devel] [PATCH proxmox-backup v3 6/7] ui: add run-on-mount checkbox to SyncJob form Hannes Laimer
2025-07-04 11:34 ` Christian Ebner
2025-06-04 12:30 ` [pbs-devel] [PATCH proxmox-backup v3 7/7] ui: add task title for triggering sync jobs Hannes Laimer
2025-07-04 12:42 ` Christian Ebner [this message]
2025-07-04 11:41 ` [pbs-devel] [PATCH-SERIES proxmox/proxmox-backup v3 0/7] trigger sync jobs on mount Christian Ebner
2025-07-16 14:54 ` [pbs-devel] superseded: " Hannes Laimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c820f33-ff8a-4d19-b808-61a9343b0a75@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal