From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Gabriel Goller <g.goller@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup v2] fix #5190: api-types: openid acr format regex
Date: Thu, 8 Feb 2024 18:22:01 +0100 [thread overview]
Message-ID: <7be8ab45-9038-416f-af09-e0de096f9614@proxmox.com> (raw)
In-Reply-To: <20240206100909.35622-1-g.goller@proxmox.com>
Am 06/02/2024 um 11:09 schrieb Gabriel Goller:
> Allow more complex strings for the acr-value when using openid. The
> openid documentation only specifies the acr-value *should* be an URI [0].
> Implemented a regex that loosely disallows some of the reserved URI
> characters specified in the RFC [1].
>
> Currently values like:
> - "urn:mace:incommon:iap:silver"
> - "urn:comsolve.nl:idp:contract:rba:location"
> do NOT work, although they are correct URI's and common acr tokens.
>
> [0]: https://openid.net/specs/openid-connect-core-1_0.html
> [1]: https://www.rfc-editor.org/rfc/rfc2396.txt
>
> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> ---
>
> v1 -> v2 changes:
> * added more context, renamed variable
>
> pbs-api-types/src/lib.rs | 5 +++++
> pbs-api-types/src/openid.rs | 7 ++++---
> 2 files changed, 9 insertions(+), 3 deletions(-)
>
>
applied, reflowed the commit message to fit in < 70 characters per
line, as per our dev docs [0], and added a reference to the PVE
change (can only help), thanks!
[0]: https://pve.proxmox.com/wiki/Developer_Documentation#Commits_and_Commit_Messages
prev parent reply other threads:[~2024-02-08 17:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 10:09 [pbs-devel] " Gabriel Goller
2024-02-08 17:22 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7be8ab45-9038-416f-af09-e0de096f9614@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox