Re: [pbs-devel] [PATCH proxmox v2 2/3] pbs-api-types: jobs: add {read, verify}-threads to VerificationJobConfig

[Christian Ebner <c.ebner@proxmox.com>]

On 11/6/25 6:43 PM, Thomas Lamprecht wrote:
> Am 06.11.25 um 17:13 schrieb Nicolas Frey:
>> controls the number of parallel threads to read/verify chunks.
>>
> 
> Any thoughts on having these options (also) in the datastore config's tuning
> options? No hard feelings for that, just something I asked myself. Can be fine
> to not do now (it's easier to add things later than having to remove them again),
> but might still warrant adding some reasoning for choosing the verification
> config here in the commit message, at least if there's the need for a v3. Could
> be fleeced in on applying otherwise.

Yes, setting this also on a datastore level for global defaults make a 
lot of sense indeed. Would allow to run regular verification's (e.g. 
immediate verification after backup) with these global defaults and 
maybe dial up the number of reads/verifies for a monthly full datastore 
verification job, running at a time where there is not much other CPU 
and IO load.

Although I'm not sure if we should place these in the tuning options, 
they are a bit crowded already. We could add dedicated 
`worker-thread-settings` to the datastore config instead? That is, if we 
commit to having these kind of knobs exposed for other workers (e.g. 
tape) as well.

What's your opinion on that?


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel