Re: [PATCH proxmox v5 13/13] s3-client: implement request counter threshold and exceeding callback

[Hannes Laimer <h.laimer@proxmox.com>]

On 2026-03-11 14:09, Christian Ebner wrote:
> Allows to set the threshold values to trigger exceeding callbacks
> for the s3 request counters.
> The globally settable callback function is executed whenever one of
> the request counters is exceeding it's set threshold value, but
> only once when passing over the threshold.
> 
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---

[..]

> +
> +    /// Update the callback executed when one of the set thresholds is exceeded
> +    pub fn update_thresholds_exceeded_callback(callback: ThresholdExceededCallback) {
> +        SHARED_COUNTER_THRESHOLD_EXCEEDED_CALLBACK
> +            .write()
> +            .unwrap()
> +            .replace(callback);
> +    }

this is called on every datastore load, so
`SHARED_COUNTER_THRESHOLD_EXCEEDED_CALLBACK` only holds the callback
associated with the latest datastore that was looked-up. Every call
would replace whatever callback was there before, at least if we don't
hit the cache...

> +
> +    /// Update the request counter thresholds to given values.
> +    pub fn update_thresholds(&self, thresholds: &RequestCounterThresholds) {
> +        self.shared_memory
> +            .data()
> +            .counters
> +            .update_thresholds(thresholds);
> +    }
>  }
>  
>  const FLUSH_THRESHOLD: Duration = Duration::from_secs(5);