From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Hannes Laimer <h.laimer@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup] api: token: make comment deletable
Date: Wed, 2 Apr 2025 18:40:46 +0200 [thread overview]
Message-ID: <79f66864-9ae7-4e6b-8495-9e45e24cabec@proxmox.com> (raw)
In-Reply-To: <20250325130406.25991-1-h.laimer@proxmox.com>
Am 25.03.25 um 14:04 schrieb Hannes Laimer:
> Currently, the only way to delete a comment on a token is to set it to
> just spaces. Since we trim it in the endpoint, it gets deleted as a
> side effect. This allows the comment to be deleted properly.
>
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
> just stumbled upon this randomly, I don't think there is a reason
> to not have it deletable
>
> src/api2/access/user.rs | 26 ++++++++++++++++++++++++++
> www/window/TokenEdit.js | 1 +
> 2 files changed, 27 insertions(+)
>
>
applied, thanks!
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2025-04-02 16:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-25 13:04 [pbs-devel] " Hannes Laimer
2025-04-02 16:40 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79f66864-9ae7-4e6b-8495-9e45e24cabec@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal