From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Gabriel Goller <g.goller@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup v3] fix #4343: updated `view_task_result` to bail on task failure
Date: Mon, 18 Sep 2023 16:40:18 +0200 [thread overview]
Message-ID: <783c6f25-b532-4cbe-9275-1514eb79b756@proxmox.com> (raw)
In-Reply-To: <20230908133219.247294-1-g.goller@proxmox.com>
Am 08/09/2023 um 15:32 schrieb Gabriel Goller:
> Now we make an additional request on `api2/json/.../tasks/{upid}/status` to
> get the `exitstatus` of the task. This allows us to `bail` and thus
> get a non-zero exit code in the cli.
>
> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> ---
>
> changes v2:
> - removed unrelated cleanup
>
> changes v1:
> - check on each iteration if the task is finished, then bubble up the
> original error of the task. This was inpractical though, so we print
> the error and return a generic error.
>
> pbs-client/src/task_log.rs | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
>
applied, thanks!
next prev parent reply other threads:[~2023-09-18 14:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-08 13:32 [pbs-devel] " Gabriel Goller
2023-09-11 6:56 ` Maximiliano Sandoval
2023-09-11 8:36 ` Gabriel Goller
2023-09-18 14:40 ` Thomas Lamprecht [this message]
2023-09-27 14:38 ` Thomas Lamprecht
2023-09-27 15:32 ` Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=783c6f25-b532-4cbe-9275-1514eb79b756@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox