* [pbs-devel] [PATCH proxmox-backup] ui: RemoteEdit: only send delete on update
@ 2020-10-02 8:32 Dominik Csapak
2020-10-02 8:48 ` [pbs-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2020-10-02 8:32 UTC (permalink / raw)
To: pbs-devel
the create api call does not understand the 'delete' paramter, so
send it only on update
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/window/RemoteEdit.js | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/www/window/RemoteEdit.js b/www/window/RemoteEdit.js
index 2296c89a..56a248e0 100644
--- a/www/window/RemoteEdit.js
+++ b/www/window/RemoteEdit.js
@@ -82,7 +82,9 @@ Ext.define('PBS.window.RemoteEdit', {
{
xtype: 'proxmoxtextfield',
hidden: true,
- deleteEmpty: true,
+ cbind: {
+ deleteEmpty: '{!isCreate}',
+ },
name: 'port',
},
],
@@ -110,13 +112,17 @@ Ext.define('PBS.window.RemoteEdit', {
{
xtype: 'proxmoxtextfield',
name: 'fingerprint',
- deleteEmpty: true,
+ cbind: {
+ deleteEmpty: '{!isCreate}',
+ },
fieldLabel: gettext('Fingerprint'),
},
{
xtype: 'proxmoxtextfield',
name: 'comment',
- deleteEmpty: true,
+ cbind: {
+ deleteEmpty: '{!isCreate}',
+ },
fieldLabel: gettext('Comment'),
},
],
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pbs-devel] applied: [PATCH proxmox-backup] ui: RemoteEdit: only send delete on update
2020-10-02 8:32 [pbs-devel] [PATCH proxmox-backup] ui: RemoteEdit: only send delete on update Dominik Csapak
@ 2020-10-02 8:48 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2020-10-02 8:48 UTC (permalink / raw)
To: Proxmox Backup Server development discussion, Dominik Csapak
On 02.10.20 10:32, Dominik Csapak wrote:
> the create api call does not understand the 'delete' paramter, so
> send it only on update
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/window/RemoteEdit.js | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-02 8:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-02 8:32 [pbs-devel] [PATCH proxmox-backup] ui: RemoteEdit: only send delete on update Dominik Csapak
2020-10-02 8:48 ` [pbs-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox