From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Christian Ebner <c.ebner@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox] acme: directory: make non-required url fields optional
Date: Tue, 22 Apr 2025 10:03:40 +0200 [thread overview]
Message-ID: <77cff8da-3125-4e9d-a524-6b59b1691083@proxmox.com> (raw)
In-Reply-To: <20250418103849.194119-1-c.ebner@proxmox.com>
Am 18.04.25 um 12:38 schrieb Christian Ebner:
> ACME servers provide the directory endpoint for clients to discover
> the URLs for ACME operation. These fields are described in RFC 8555
> [0], but section 7.1 of the corresponding RFC [1] states that the
> server is only required to provide the `directory` and `newNonce`
> resources.
>
> Therefore, make the not explicitly required fields optional to not
> fail during deserialization of the json response and improve error
> handling when the acme client actually requires the not-provided
> operation url.
>
> This was discovered based on issues reported in the community forum.
What about the perl implementation in PVE/PMG, or is that not affected
of this issue?
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-04-22 8:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-18 10:38 Christian Ebner
2025-04-22 8:03 ` Thomas Lamprecht [this message]
2025-04-28 8:49 ` Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77cff8da-3125-4e9d-a524-6b59b1691083@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal