[pbs-devel] [PATCH proxmox] notify: remove irritating 'html template not found' log message

[pbs-devel] [PATCH proxmox] notify: remove irritating 'html template not found' log message

[Lukas Wagner]

The proxmox-notify crate can render notification text based on two
different templates, plaintext and html. The html template is at the
moment only used for email-based notifications. If we try to render
a html-formatted message but there is no html template, we try to
fall back to the plaintext template and wrap the rendered message
in <pre> tags.
As a preparation for user-supplied/overridden templates, I added a log
message "html template not found, falling back to plaintext ..." to
educate the user about this behavior.

In Proxmox Backup Server, we only ship plaintext templates at the
moment, meaning that this log message will be shown for every single
(email) notification that is sent out. This might be a bit confusing,
because the log message can be interpreted as an error, which it isn't.

This commit removes the log message completely for now. Once we add
support for user-overridable notification templates we could consider
adding it back it, but maybe phrased a bit differently, to avoid it
being interpreted as an error.

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
 proxmox-notify/src/renderer/mod.rs | 1 -
 1 file changed, 1 deletion(-)

diff --git a/proxmox-notify/src/renderer/mod.rs b/proxmox-notify/src/renderer/mod.rs
index 82473d03..393cbbf2 100644
--- a/proxmox-notify/src/renderer/mod.rs
+++ b/proxmox-notify/src/renderer/mod.rs
@@ -290,7 +290,6 @@ pub fn render_template(
         (None, TemplateType::HtmlBody) => {
             ty = TemplateType::PlaintextBody;
             let plaintext_filename = format!("{template}-{suffix}", suffix = ty.file_suffix());
-            log::info!("html template '{filename}' not found, falling back to plain text template '{plaintext_filename}'");
             (
                 context::context().lookup_template(&plaintext_filename, None)?,
                 true,
-- 
2.39.5



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] applied: [PATCH proxmox] notify: remove irritating 'html template not found' log message

[Thomas Lamprecht]

Am 26.11.24 um 10:30 schrieb Lukas Wagner:
> The proxmox-notify crate can render notification text based on two
> different templates, plaintext and html. The html template is at the
> moment only used for email-based notifications. If we try to render
> a html-formatted message but there is no html template, we try to
> fall back to the plaintext template and wrap the rendered message
> in <pre> tags.
> As a preparation for user-supplied/overridden templates, I added a log
> message "html template not found, falling back to plaintext ..." to
> educate the user about this behavior.
> 
> In Proxmox Backup Server, we only ship plaintext templates at the
> moment, meaning that this log message will be shown for every single
> (email) notification that is sent out. This might be a bit confusing,
> because the log message can be interpreted as an error, which it isn't.
> 
> This commit removes the log message completely for now. Once we add
> support for user-overridable notification templates we could consider
> adding it back it, but maybe phrased a bit differently, to avoid it
> being interpreted as an error.
> 
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
>  proxmox-notify/src/renderer/mod.rs | 1 -
>  1 file changed, 1 deletion(-)
> 
>

applied, thanks!

Anything pending for the notify crate? As else I'd do a bump now already.


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

Re: [pbs-devel] applied: [PATCH proxmox] notify: remove irritating 'html template not found' log message

[Lukas Wagner]

On  2024-11-26 12:09, Thomas Lamprecht wrote:
> applied, thanks!
> 
> Anything pending for the notify crate? As else I'd do a bump now already.
> 
> 

As mentioned off-list, the only thing left open for proxmox-notify at the moment is

https://lore.proxmox.com/pve-devel/20241122100815.67255-1-l.wagner@proxmox.com/T/

Also requires a bump for proxmox-http, not sure if we want to do this at the moment
or later.

-- 
- Lukas


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel