From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Christian Ebner <c.ebner@proxmox.com>,
Christoph Heiss <c.heiss@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox v2] sys: file: use renameat2() from `nix` crate
Date: Thu, 18 Jul 2024 14:03:54 +0200 [thread overview]
Message-ID: <772481c8-3bb6-42c7-95ef-29074819f00c@proxmox.com> (raw)
In-Reply-To: <1626412400.1424.1721301545661@webmail.proxmox.com>
Am 18/07/2024 um 13:19 schrieb Christian Ebner:
> Partially my fault, as I overlooked in my suggestion that linkat() does not accept `AtFlags` in version 0.26.1 just yet [0].
> The suggested replacement type is however already there, but the module namespace is incorrect in the patch. Should have been [1].
>
> [0] https://docs.rs/nix/0.26.1/nix/unistd/fn.linkat.html
> [1] https://docs.rs/nix/0.26.1/nix/fcntl/struct.AtFlags.html
>
The type is there, but isn't accepted by `nix::unistd::linkat`, nor is there
a variant of that method that would accept it in this version FWICS.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-07-18 12:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-12 7:54 Christoph Heiss
2024-07-12 8:16 ` Turkijan
2024-07-12 9:39 ` Christian Ebner
2024-07-18 10:29 ` Thomas Lamprecht
2024-07-18 11:19 ` Christian Ebner
2024-07-18 12:03 ` Thomas Lamprecht [this message]
2024-07-18 12:13 ` Christian Ebner
2024-07-18 12:19 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=772481c8-3bb6-42c7-95ef-29074819f00c@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox