From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Gabriel Goller <g.goller@proxmox.com>
Subject: Re: [pbs-devel] [PATCH widget-toolkit v4 1/7] utils: add base64 conversion helper
Date: Tue, 26 Nov 2024 12:06:24 +0100 [thread overview]
Message-ID: <738f24b2-c679-43f7-8fd0-e242676dcc4e@proxmox.com> (raw)
In-Reply-To: <mzrxuz23zeglfm63c5nx3ypyq6femgfq4fc3p4qz27w5h54zip@bfz6n3wsw4p7>
Am 26.11.24 um 11:31 schrieb Gabriel Goller:
> On 17.09.2024 09:37, Thomas Lamprecht wrote:
>> FWIW this could be a bit shorter by using map (which typed arrays
>> also support [0]):
>>
>> const escapedString = bytes.map(b => String.fromCodePoint(b)).join('');
>>
>> But for that we really need no new revision.
>>
>> [0]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/map
>
> I just tried this and it sadly doesn't work. `String.fromCodePoint`
> returns a string, which can't be stored in the `Uint8Array` which is `bytes`.
You are right, sorry for the misdirection.
One would need the non-typed array method for that, i.e.:
var escapedString = Array.prototype.map.call(bytes, b => String.fromCodePoint(b)).join('');
Which really is not nicer than what you did, so let's go with that.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-11-26 11:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 13:10 [pbs-devel] [PATCH proxmox{, -backup}/widget-toolkit v4 0/7] fix #5463: add optional consent banner before login Gabriel Goller
2024-09-13 13:10 ` [pbs-devel] [PATCH widget-toolkit v4 1/7] utils: add base64 conversion helper Gabriel Goller
2024-09-17 7:37 ` Thomas Lamprecht
2024-11-26 10:31 ` Gabriel Goller
2024-11-26 11:06 ` Thomas Lamprecht [this message]
2024-09-13 13:10 ` [pbs-devel] [PATCH widget-toolkit v4 2/7] window: add consent modal Gabriel Goller
2024-11-25 17:26 ` [pbs-devel] applied: " Thomas Lamprecht
2024-09-13 13:10 ` [pbs-devel] [PATCH widget-toolkit v4 3/7] form: add support for multiline textarea Gabriel Goller
2024-11-25 17:26 ` [pbs-devel] applied: " Thomas Lamprecht
2024-09-13 13:10 ` [pbs-devel] [PATCH proxmox v4 4/7] rest-server: add custom handlebars escape fn Gabriel Goller
2024-11-25 15:39 ` [pbs-devel] applied: " Thomas Lamprecht
2024-09-13 13:10 ` [pbs-devel] [PATCH proxmox-backup v4 5/7] api: add consent api handler and config option Gabriel Goller
2024-11-25 18:11 ` [pbs-devel] applied: " Thomas Lamprecht
2024-09-13 13:10 ` [pbs-devel] [PATCH proxmox-backup v4 6/7] ui: show consent banner before login Gabriel Goller
2024-11-25 18:12 ` [pbs-devel] applied: " Thomas Lamprecht
2024-11-26 10:01 ` Gabriel Goller
2024-09-13 13:10 ` [pbs-devel] [PATCH proxmox-backup v4 7/7] docs: add section about consent banner Gabriel Goller
2024-11-25 18:13 ` [pbs-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=738f24b2-c679-43f7-8fd0-e242676dcc4e@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox