From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stoiko Ivanov <s.ivanov@proxmox.com>,
pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [pve-devel] [RFC zfsonlinux 1/1] Add systemd-unit for importing specific pools
Date: Tue, 29 Sep 2020 05:54:19 +0200 [thread overview]
Message-ID: <7386d18b-da4b-8384-a2d7-3277b1076f8b@proxmox.com> (raw)
In-Reply-To: <20200916121419.3997-2-s.ivanov@proxmox.com>
On 16.09.20 14:14, Stoiko Ivanov wrote:
> [ --8<-- snip --8<-- ]
> +diff --git a/etc/systemd/system/zfs-import@.service.in b/etc/systemd/system/zfs-import@.service.in
> +new file mode 100644
> +index 000000000..2db9fdaab
> +--- /dev/null
> ++++ b/etc/systemd/system/zfs-import@.service.in
> +@@ -0,0 +1,17 @@
> ++[Unit]
> ++Description=Import ZFS pool %i
> ++Documentation=man:zpool(8)
> ++DefaultDependencies=no
> ++Requires=systemd-udev-settle.service
The after below can be OK, but why the require??
"Using this service is not recommended. [...]"
-- https://www.freedesktop.org/software/systemd/man/systemd-udev-settle.service.html
> ++After=systemd-udev-settle.service
> ++After=cryptsetup.target
> ++After=multipathd.target
> ++Before=zfs-import.target
> ++
> ++[Service]
> ++Type=oneshot
> ++RemainAfterExit=yes
> ++ExecStart=@sbindir@/zpool import -N -d /dev/disk/by-id -o cachefile=none %I
> ++
> ++[Install]
> ++WantedBy=zfs-import.target
next prev parent reply other threads:[~2020-09-29 3:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 12:14 [pbs-devel] [RFC proxmox-backup/storage/zfsonlinux] improve zpool import for freshly created zpools Stoiko Ivanov
2020-09-16 12:14 ` [pbs-devel] [RFC zfsonlinux 1/1] Add systemd-unit for importing specific pools Stoiko Ivanov
2020-09-29 3:54 ` Thomas Lamprecht [this message]
2020-09-29 13:03 ` [pbs-devel] applied: [pve-devel] " Thomas Lamprecht
2020-09-16 12:14 ` [pbs-devel] [RFC proxmox-backup 1/1] api2/node/disks/zfs: instantiate import service Stoiko Ivanov
2020-09-30 7:35 ` [pbs-devel] applied: " Thomas Lamprecht
2020-09-16 12:14 ` [pbs-devel] [RFC storage 1/1] Disks: instantiate import unit for created zpool Stoiko Ivanov
2020-09-29 16:58 ` [pbs-devel] applied: [pve-devel] " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7386d18b-da4b-8384-a2d7-3277b1076f8b@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox