Re: [PATCH proxmox-backup v4 6/7] ui: add move group action

[Christian Ebner <c.ebner@proxmox.com>]

One comment inline.

On 3/11/26 4:13 PM, Hannes Laimer wrote:
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
>   www/Makefile             |  1 +
>   www/datastore/Content.js | 61 ++++++++++++++++++++++++++++++++++++++++
>   www/window/GroupMove.js  | 56 ++++++++++++++++++++++++++++++++++++
>   3 files changed, 118 insertions(+)
>   create mode 100644 www/window/GroupMove.js
> 
> diff --git a/www/Makefile b/www/Makefile
> index 9ebf0445..db775b64 100644
> --- a/www/Makefile
> +++ b/www/Makefile
> @@ -77,6 +77,7 @@ JSSRC=							\
>   	window/ACLEdit.js				\
>   	window/BackupGroupChangeOwner.js		\
>   	window/CreateDirectory.js			\
> +	window/GroupMove.js				\
>   	window/DataStoreEdit.js				\
>   	window/NamespaceEdit.js				\
>   	window/MaintenanceOptions.js			\
> diff --git a/www/datastore/Content.js b/www/datastore/Content.js
> index a2aa1949..ccd48616 100644
> --- a/www/datastore/Content.js
> +++ b/www/datastore/Content.js
> @@ -635,6 +635,50 @@ Ext.define('PBS.DataStoreContent', {
>               });
>           },
>   
> +        moveNS: function () {
> +            let me = this;
> +            let view = me.getView();
> +            if (!view.namespace || view.namespace === '') {
> +                return;
> +            }
> +            let win = Ext.create('PBS.window.NamespaceMove', {
> +                datastore: view.datastore,
> +                namespace: view.namespace,
> +                taskDone: (success) => {
> +                    if (success) {
> +                        let newNs = win.getNewNamespace();
> +                        view.down('pbsNamespaceSelector').store?.load();
> +                        me.nsChange(null, newNs);
> +                    }
> +                },
> +            });
> +            win.show();
> +        },
> +
> +        moveGroup: function (data) {
> +            let me = this;
> +            let view = me.getView();
> +            let group = `${data.backup_type}/${data.backup_id}`;
> +            Ext.create('PBS.window.GroupMove', {
> +                datastore: view.datastore,
> +                namespace: view.namespace,
> +                backupType: data.backup_type,
> +                backupId: data.backup_id,
> +                group,
> +                taskDone: () => me.reload(),
> +            }).show();
> +        },
> +
> +        onMove: function (table, rI, cI, item, e, { data }) {
> +            let me = this;
> +            if (data.ty === 'group') {
> +                me.moveGroup(data);
> +            } else if (data.ty === 'ns') {
> +                me.moveNS();
> +            }
> +        },
> +
> +
>           forgetGroup: function (data) {
>               let me = this;
>               let view = me.getView();
> @@ -1080,6 +1124,23 @@ Ext.define('PBS.DataStoreContent', {
>                       },
>                       isActionDisabled: (v, r, c, i, rec) => rec.data.ty !== 'dir',
>                   },
> +                {
> +                    handler: 'onMove',
> +                    getTip: (v, m, { data }) => {
> +                        if (data.ty === 'group') {
> +                            return Ext.String.format(gettext("Move group '{0}'"), v);
> +                        }
> +                        return Ext.String.format(gettext("Move namespace '{0}'"), v);
> +                    },
> +                    getClass: (v, m, { data }) => {
> +                        if (data.ty === 'group') { return 'fa fa-arrows'; }
> +                        if (data.ty === 'ns' && !data.isRootNS && data.ns === undefined) {
> +                            return 'fa fa-arrows';
> +                        }
> +                        return 'pmx-hidden';
> +                    },
> +                    isActionDisabled: (v, r, c, i, { data }) => false,
> +                },

comment: placing this right before the prune icon is a bit dangerous 
(although a prune will ask for confirmation).

Since the protected icons is not shown for groups and namespaces, it 
should rather be placed before that, right after the verification icon.

Further, what I missed is having this also in the context menu opened on 
right click of the group/namespace.

>                   {
>                       handler: 'onForget',
>                       getTip: (v, m, { data }) => {
> diff --git a/www/window/GroupMove.js b/www/window/GroupMove.js
> new file mode 100644
> index 00000000..f663c606
> --- /dev/null
> +++ b/www/window/GroupMove.js
> @@ -0,0 +1,56 @@
> +Ext.define('PBS.window.GroupMove', {
> +    extend: 'Proxmox.window.Edit',
> +    alias: 'widget.pbsGroupMove',
> +    mixins: ['Proxmox.Mixin.CBind'],
> +
> +    onlineHelp: 'storage-namespaces',
> +
> +    isCreate: true,
> +    submitText: gettext('Move'),
> +    showTaskViewer: true,
> +
> +    cbind: {
> +        url: '/api2/extjs/admin/datastore/{datastore}/groups',
> +        title: (get) => Ext.String.format(gettext("Move Backup Group '{0}'"), get('group')),
> +    },
> +    method: 'PUT',
> +
> +    width: 400,
> +    fieldDefaults: {
> +        labelWidth: 120,
> +    },
> +
> +    items: {
> +        xtype: 'inputpanel',
> +        onGetValues: function (values) {
> +            let win = this.up('window');
> +            let result = {
> +                'backup-type': win.backupType,
> +                'backup-id': win.backupId,
> +                'new-ns': values['new-ns'] || '',
> +            };
> +            if (win.namespace && win.namespace !== '') {
> +                result.ns = win.namespace;
> +            }
> +            return result;
> +        },
> +        items: [
> +            {
> +                xtype: 'displayfield',
> +                fieldLabel: gettext('Group'),
> +                cbind: {
> +                    value: '{group}',
> +                },
> +            },
> +            {
> +                xtype: 'pbsNamespaceSelector',
> +                name: 'new-ns',
> +                fieldLabel: gettext('Target Namespace'),
> +                allowBlank: true,
> +                cbind: {
> +                    datastore: '{datastore}',
> +                },
> +            },
> +        ],
> +    },
> +});