From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied-series: [PATCH proxmox-backup 1/3] ui: form/GroupFilter: correctly resolve the reference cycle
Date: Wed, 1 Dec 2021 14:33:14 +0100 [thread overview]
Message-ID: <714a29ca-9365-80a7-e141-6fcaefd67da1@proxmox.com> (raw)
In-Reply-To: <20211201105708.3150068-1-d.csapak@proxmox.com>
On 01.12.21 11:57, Dominik Csapak wrote:
> 'record[widget]' does not contain anything since the widgets are
> in the 'widgets' property so delete that
>
> we also have to remove the 'record' entry of the widget so that
> the widget does not have a link to the record anymore
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/form/GroupFilter.js | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>
applied series, thanks! Added a patch that merges duplicate filter-entries
on top.
As mentioned off-list, ideally we'd let our combo grid cope with shared stores,
then we could use a single backing store for all group fields, which would be
more efficient too, anyhow, for now this is just fine as is.
prev parent reply other threads:[~2021-12-01 13:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 10:57 [pbs-devel] " Dominik Csapak
2021-12-01 10:57 ` [pbs-devel] [PATCH proxmox-backup 2/3] ui: form/GroupFilter: improve group load callback handling Dominik Csapak
2021-12-01 10:57 ` [pbs-devel] [PATCH proxmox-backup 3/3] ui: form/GroupFilter: copy records for the pbsGroupSelectors Dominik Csapak
2021-12-01 13:33 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=714a29ca-9365-80a7-e141-6fcaefd67da1@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox