From: Lukas Wagner <l.wagner@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Hannes Laimer <h.laimer@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 0/4] native local sync-jobs
Date: Tue, 14 Feb 2023 09:02:16 +0100 [thread overview]
Message-ID: <6f920450-061d-850f-1380-76d1a79eac14@proxmox.com> (raw)
In-Reply-To: <20230213154555.49610-1-h.laimer@proxmox.com>
On 2/13/23 16:45, Hannes Laimer wrote:
> Add support for local sync. Sync-jobs without
> a remote are considered local, and use a
> different logic for pulling. The main reason
> for not reusing the existing pull logic is
> that the current logic relies on having a
> HttpClient and without a remote we can't create
> one. Having separate logic for local pulling
> however should speed up local syncs a bit,
> and for syncs in the same datastore, chunck
> transmission can be skipped all together.
> Also the autocompletion and UI is updated
> to support local sync-jobs.
>
> The new logic is mostly adding a local
> alternative whenever the HttpClient is used.
> Since the pulling process involves a lot of
> functions calling functions to do smaller stuff
> it was not really possible to split the changes
> up more.
>
Gave this a quick spin on the latest master, here's what I tested:
* Local syncing withing the same datastore (between different namespaces)
* Local syncing between different datastores
* Remote syncing to a different PBS instance, to make sure that nothing broke
Everything seems to work as expected. Consider these patches:
Tested-by: Lukas Wagner <l.wagner@proxmox.com>
prev parent reply other threads:[~2023-02-14 8:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 15:45 Hannes Laimer
2023-02-13 15:45 ` [pbs-devel] [PATCH proxmox-backup 1/4] api2: make remote for sync-jobs optional Hannes Laimer
2023-02-14 14:33 ` Fabian Grünbichler
2023-02-15 11:40 ` Thomas Lamprecht
2023-02-16 8:02 ` Fabian Grünbichler
2023-02-13 15:45 ` [pbs-devel] [PATCH proxmox-backup 2/4] pull: add logic for local pull Hannes Laimer
2023-02-14 14:33 ` Fabian Grünbichler
2023-02-13 15:45 ` [pbs-devel] [PATCH proxmox-backup 3/4] manager: add completion for local sync-jobs Hannes Laimer
2023-02-13 15:45 ` [pbs-devel] [PATCH proxmox-backup 4/4] ui: add ui support " Hannes Laimer
2023-02-14 8:02 ` Lukas Wagner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f920450-061d-850f-1380-76d1a79eac14@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox