[pbs-devel] [PATCH proxmox-backup] client: backup writer: fix regression in progress output

[pbs-devel] [PATCH proxmox-backup] client: backup writer: fix regression in progress output

[Christian Ebner]

Fixes a regression introduced when switching from the plain string
to be used for archive names to the BackupArchiveName api type in
commit addfae26 ("api types: introduce `BackupArchiveName` type").

The archive name now always is stored including the server archive
name extension. Adapt the check for which archive types to display
the progress log output to reflect this change.

Fixes: addfae26 ("api types: introduce `BackupArchiveName` type")
Reported-by: Max Carrara <m.carrara@proxmox.com>
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 pbs-client/src/backup_writer.rs | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/pbs-client/src/backup_writer.rs b/pbs-client/src/backup_writer.rs
index baf2aebb1..f321ea403 100644
--- a/pbs-client/src/backup_writer.rs
+++ b/pbs-client/src/backup_writer.rs
@@ -847,9 +847,9 @@ impl BackupWriter {
         let (upload_queue, upload_result) =
             Self::append_chunk_queue(h2.clone(), wid, append_chunk_path, uploaded_len.clone());
 
-        let progress_handle = if archive.ends_with(".img")
-            || archive.ends_with(".pxar")
-            || archive.ends_with(".ppxar")
+        let progress_handle = if archive.ends_with(".img.fidx")
+            || archive.ends_with(".pxar.didx")
+            || archive.ends_with(".ppxar.didx")
         {
             let counters = counters.clone();
             Some(tokio::spawn(async move {
-- 
2.39.5



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] applied: [PATCH proxmox-backup] client: backup writer: fix regression in progress output

[Thomas Lamprecht]

Am 26.11.24 um 17:14 schrieb Christian Ebner:
> Fixes a regression introduced when switching from the plain string
> to be used for archive names to the BackupArchiveName api type in
> commit addfae26 ("api types: introduce `BackupArchiveName` type").
> 
> The archive name now always is stored including the server archive
> name extension. Adapt the check for which archive types to display
> the progress log output to reflect this change.
> 
> Fixes: addfae26 ("api types: introduce `BackupArchiveName` type")
> Reported-by: Max Carrara <m.carrara@proxmox.com>
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
>  pbs-client/src/backup_writer.rs | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
>

applied, thanks!


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel