From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: Re: [pbs-devel] [PATCH backup] api: add world accessible ping dummy endpoint
Date: Thu, 22 Oct 2020 12:34:42 +0200 [thread overview]
Message-ID: <6c818c31-58c2-afaf-f6a0-7d2404e1fc57@proxmox.com> (raw)
In-Reply-To: <1603354658.wifegpzioo.astroid@nora.none>
On 22.10.20 10:18, Fabian Grünbichler wrote:
> On October 21, 2020 8:32 pm, Thomas Lamprecht wrote:
>> On 05.10.20 16:57, Thomas Lamprecht wrote:
>>> This is indented to be used for the PVE storage library, replacing
>>> the missuse of the much more expensive status API call.
>>>
>>> Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
>>> ---
>>>
>>> I initially thought about adding this to the proxmox-backup-client as command,
>>> but it's not much of use there (user can just use the version command) and for
>>> the PVE integration we can do a simple http request with LWP, which is much
>>> cheaper than fork+exec the client there.
>>>
>>
>> any objections to this? Else I'd apply it as is..
>
> LGTM, maybe besides that having a separate file for this instead of just
> inlining it into api2.rs seems overkill :-P
>
Thought so first too, but it made the top level API entry point quite a bit uglier,
more noisier, and as the separate file does not costs much I went for that way :)
next prev parent reply other threads:[~2020-10-22 10:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 14:57 Thomas Lamprecht
2020-10-21 18:32 ` Thomas Lamprecht
2020-10-22 8:18 ` Fabian Grünbichler
2020-10-22 10:34 ` Thomas Lamprecht [this message]
2020-10-24 17:14 ` [pbs-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c818c31-58c2-afaf-f6a0-7d2404e1fc57@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox