From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Christian Ebner <c.ebner@proxmox.com>
Subject: [pbs-devel] applied-series: [PATCH v2 proxmox-backup 1/3] api types: version: drop unused `repoid` field
Date: Mon, 2 Dec 2024 15:30:08 +0100 [thread overview]
Message-ID: <6bd8b9c3-2a66-4324-9ac4-db0461c4de28@proxmox.com> (raw)
In-Reply-To: <20241128160721.583578-1-c.ebner@proxmox.com>
Am 28.11.24 um 17:07 schrieb Christian Ebner:
> The `ApiVersion` type was introduced in commit a926803b
> ("api/api-types: refactor api endpoint version, add api types")
> including the `repoid`, added for completeness when converting from
> a pre-existing `ApiVersionInfo` instance, as returned by the
> `version` api endpoint.
>
> Drop the additional `repoid` field, since this is currently not used,
> can be obtained fro the `ApiVersionInfo` as well and only hinders the
> implementation for easy api version comparison.
>
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
> changes since version 1:
> - not present in previous version
>
> pbs-api-types/src/version.rs | 2 --
> 1 file changed, 2 deletions(-)
>
>
applied all three patches, it's really nicer this way, thanks!
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2024-12-02 14:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-28 16:07 [pbs-devel] " Christian Ebner
2024-11-28 16:07 ` [pbs-devel] [PATCH v2 proxmox-backup 2/3] api types: version: implement traits to allow for version comparison Christian Ebner
2024-11-28 16:07 ` [pbs-devel] [PATCH v2 proxmox-backup 3/3] sync: push: use direct api version comparison in compatibility checks Christian Ebner
2024-12-02 14:30 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bd8b9c3-2a66-4324-9ac4-db0461c4de28@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox