public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pbs-devel] [PATCH proxmox-backup] ui: utils: add task description for mounting/unmounting
@ 2024-11-26 10:15 Dominik Csapak
  2024-11-26 10:39 ` Fabian Grünbichler
  0 siblings, 1 reply; 3+ messages in thread
From: Dominik Csapak @ 2024-11-26 10:15 UTC (permalink / raw)
  To: pbs-devel

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/Utils.js | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/www/Utils.js b/www/Utils.js
index 6bae9b709..484c607bd 100644
--- a/www/Utils.js
+++ b/www/Utils.js
@@ -417,6 +417,7 @@ Ext.define('PBS.Utils', {
 	    'label-media': [gettext('Drive'), gettext('Label Media')],
 	    'load-media': (type, id) => PBS.Utils.render_drive_load_media_id(id, gettext('Load Media')),
 	    logrotate: [null, gettext('Log Rotation')],
+	    'mount-device': [gettext('Datastore'), gettext('Mount Device')],
 	    prune: (type, id) => PBS.Utils.render_datastore_worker_id(id, gettext('Prune')),
 	    prunejob: (type, id) => PBS.Utils.render_prune_job_worker_id(id, gettext('Prune Job')),
 	    reader: (type, id) => PBS.Utils.render_datastore_worker_id(id, gettext('Read Objects')),
@@ -427,6 +428,7 @@ Ext.define('PBS.Utils', {
 	    'tape-backup-job': (type, id) => PBS.Utils.render_tape_backup_id(id, gettext('Tape Backup Job')),
 	    'tape-restore': ['Datastore', gettext('Tape Restore')],
 	    'unload-media': [gettext('Drive'), gettext('Unload Media')],
+	    'unmount-device': [gettext('Datastore'), gettext('Un-mount Device')],
 	    verificationjob: [gettext('Verify Job'), gettext('Scheduled Verification')],
 	    verify: ['Datastore', gettext('Verification')],
 	    verify_group: ['Group', gettext('Verification')],
-- 
2.39.5



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [pbs-devel] [PATCH proxmox-backup] ui: utils: add task description for mounting/unmounting
  2024-11-26 10:15 [pbs-devel] [PATCH proxmox-backup] ui: utils: add task description for mounting/unmounting Dominik Csapak
@ 2024-11-26 10:39 ` Fabian Grünbichler
  2024-11-26 10:46   ` Dominik Csapak
  0 siblings, 1 reply; 3+ messages in thread
From: Fabian Grünbichler @ 2024-11-26 10:39 UTC (permalink / raw)
  To: Proxmox Backup Server development discussion

On November 26, 2024 11:15 am, Dominik Csapak wrote:
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  www/Utils.js | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/www/Utils.js b/www/Utils.js
> index 6bae9b709..484c607bd 100644
> --- a/www/Utils.js
> +++ b/www/Utils.js
> @@ -417,6 +417,7 @@ Ext.define('PBS.Utils', {
>  	    'label-media': [gettext('Drive'), gettext('Label Media')],
>  	    'load-media': (type, id) => PBS.Utils.render_drive_load_media_id(id, gettext('Load Media')),
>  	    logrotate: [null, gettext('Log Rotation')],
> +	    'mount-device': [gettext('Datastore'), gettext('Mount Device')],
>  	    prune: (type, id) => PBS.Utils.render_datastore_worker_id(id, gettext('Prune')),
>  	    prunejob: (type, id) => PBS.Utils.render_prune_job_worker_id(id, gettext('Prune Job')),
>  	    reader: (type, id) => PBS.Utils.render_datastore_worker_id(id, gettext('Read Objects')),
> @@ -427,6 +428,7 @@ Ext.define('PBS.Utils', {
>  	    'tape-backup-job': (type, id) => PBS.Utils.render_tape_backup_id(id, gettext('Tape Backup Job')),
>  	    'tape-restore': ['Datastore', gettext('Tape Restore')],
>  	    'unload-media': [gettext('Drive'), gettext('Unload Media')],
> +	    'unmount-device': [gettext('Datastore'), gettext('Un-mount Device')],

nit: I'd prefer "Unmount" instead of "Un-mount". we don't have a single
"Un-" in the whole codebase AFAICT ;)

>  	    verificationjob: [gettext('Verify Job'), gettext('Scheduled Verification')],
>  	    verify: ['Datastore', gettext('Verification')],
>  	    verify_group: ['Group', gettext('Verification')],
> -- 
> 2.39.5
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
> 
> 


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [pbs-devel] [PATCH proxmox-backup] ui: utils: add task description for mounting/unmounting
  2024-11-26 10:39 ` Fabian Grünbichler
@ 2024-11-26 10:46   ` Dominik Csapak
  0 siblings, 0 replies; 3+ messages in thread
From: Dominik Csapak @ 2024-11-26 10:46 UTC (permalink / raw)
  To: Proxmox Backup Server development discussion, Fabian Grünbichler

done, sent a v2:
https://lore.proxmox.com/pbs-devel/20241126104549.1288016-1-d.csapak@proxmox.com/


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-11-26 10:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-26 10:15 [pbs-devel] [PATCH proxmox-backup] ui: utils: add task description for mounting/unmounting Dominik Csapak
2024-11-26 10:39 ` Fabian Grünbichler
2024-11-26 10:46   ` Dominik Csapak

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal