public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Philipp Hufnagl <p.hufnagl@proxmox.com>,
	Lukas Wagner <l.wagner@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 1/3] fix #4315: jobs: modify GroupFilter so include/exclude is tracked
Date: Wed, 25 Oct 2023 15:33:30 +0200	[thread overview]
Message-ID: <69df7927-de20-4301-a785-2a57d53fcf2b@proxmox.com> (raw)
In-Reply-To: <dc0cc081-ee54-4016-af3f-9a372faba9d1@proxmox.com>

Am 24/10/2023 um 16:32 schrieb Philipp Hufnagl:
> 
> 
> On 10/24/23 12:43, Lukas Wagner wrote:
> 
>> Do you have any examples in mind that would be more difficult to
>> represent?
> 
> I would like to include all vms from 10 to to 30, but not 17,18 and 20.
> 

How is that more difficult?

IMO Lukas proposal seems reasonable, a deterministic remove matches from
excludes fromm all matches from includes seems easier to understand,
from top of my head.




  reply	other threads:[~2023-10-25 13:34 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-23 15:42 [pbs-devel] [PATCH proxmox-backup 0/3] fix #4315: datastore: Exclude entries from sync Philipp Hufnagl
2023-10-23 15:43 ` [pbs-devel] [PATCH proxmox-backup 1/3] fix #4315: jobs: modify GroupFilter so include/exclude is tracked Philipp Hufnagl
2023-10-24  9:18   ` Lukas Wagner
2023-10-24  9:54     ` Philipp Hufnagl
2023-10-24 10:43       ` Lukas Wagner
2023-10-24 14:32         ` Philipp Hufnagl
2023-10-25 13:33           ` Thomas Lamprecht [this message]
2023-10-25 15:07             ` Philipp Hufnagl
2023-10-25 15:45               ` Thomas Lamprecht
2023-11-07  7:43                 ` Wolfgang Bumiller
2023-11-07  7:55                   ` Thomas Lamprecht
2023-11-07  8:26                     ` Wolfgang Bumiller
2023-11-07  9:01                       ` Dominik Csapak
2023-11-07 11:10                         ` Thomas Lamprecht
2023-11-07 11:07                       ` Thomas Lamprecht
2023-10-23 15:43 ` [pbs-devel] [PATCH proxmox-backup 2/3] ui: Show if Filter includes or excludes Philipp Hufnagl
2023-10-24 12:20   ` Lukas Wagner
2023-10-24 12:27   ` Lukas Wagner
2023-10-24 12:36     ` Philipp Hufnagl
2023-10-24 14:09       ` Philipp Hufnagl
2023-10-24 14:12         ` Lukas Wagner
2023-10-27  9:29           ` Thomas Lamprecht
2023-10-23 15:43 ` [pbs-devel] [PATCH proxmox-backup 3/3] docs: document new include/exclude paramenter Philipp Hufnagl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69df7927-de20-4301-a785-2a57d53fcf2b@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=l.wagner@proxmox.com \
    --cc=p.hufnagl@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal