public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>, Daniel Kral <d.kral@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup v3 1/2] pbs2to3: fix #5600: expect any kernel 6.x version above 6.2.16
Date: Tue, 10 Sep 2024 16:16:11 +0200	[thread overview]
Message-ID: <69cfbb04-0c3c-4972-8b98-00c648ea6bd4@proxmox.com> (raw)
In-Reply-To: <20240829144137.166940-1-d.kral@proxmox.com>

Am 29.08.24 um 16:41 schrieb Daniel Kral:
> Fixes a minor bug where `pbs2to3` shows an incorrect warning about an
> incompatible kernel version, where newer kernel versions than 6.5.* were
> marked as unexpected.
> 
> Signed-off-by: Daniel Kral <d.kral@proxmox.com>
> ---
> no diff to v1/v2.
> 
>  src/bin/pbs2to3.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/bin/pbs2to3.rs b/src/bin/pbs2to3.rs
> index 1f895abd..194a077e 100644
> --- a/src/bin/pbs2to3.rs
> +++ b/src/bin/pbs2to3.rs
> @@ -130,7 +130,7 @@ impl Checker {
>          self.output.log_info("Check running kernel version..")?;
>          let (krunning, kinstalled) = if self.upgraded {
>              (
> -                Regex::new(r"^6\.(?:2\.(?:[2-9]\d+|1[6-8]|1\d\d+)|5)[^~]*$")?,
> +                Regex::new(r"^6\.(?:2\.(?:[2-9]\d+|1[6-8]|1\d\d+)|([5-9]|\d{2,}))[^~]*$")?,
>                  "proxmox-kernel-6.2",
>              )
>          } else {

Sorry, forgot to check for newer versions of the patch series, so
answering again as it's still relevant:

In PVE and PMG we allow arbitrary newer -pve kernels for
future-proofing, it would be nice to do the same here too:

https://git.proxmox.com/?p=pve-manager.git;a=commit;h=fb59038a8b110b0b0b438ec035fd41dd9d591232

https://git.proxmox.com/?p=pmg-api.git;a=commit;h=9d67a9af218b73027822c9c4665b88e6662e7ef7


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


  parent reply	other threads:[~2024-09-10 14:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-29 14:41 Daniel Kral
2024-08-29 14:41 ` [pbs-devel] [PATCH proxmox-backup v3 2/2] pbs2to3: add test cases for kernel version compatibility Daniel Kral
2024-09-10 14:16 ` Fiona Ebner [this message]
2024-09-18 13:08   ` [pbs-devel] [PATCH proxmox-backup v3 1/2] pbs2to3: fix #5600: expect any kernel 6.x version above 6.2.16 Daniel Kral

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69cfbb04-0c3c-4972-8b98-00c648ea6bd4@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=d.kral@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal