Re: [pbs-devel] [PATCH proxmox-backup 00/15] (partially)close #3156: Add support for removable datastores

[Lorenz Stechauner <l.stechauner@proxmox.com>]

Hi,

after fighting against the Rust compiler and PBS datastores, I was 
finally able to test this series :)

Everything works as expected, with some room for improvements:

* I accidentally achieved that the root partition was the 
backing-storage of my removable datastore. Unmounting this datastore 
lead to the root partition being unmounted – not ideal. I can imagine 
two possible solutions: 1.) do not ever unmount "/" (check before 
unmounting) and 2.) check on creation of the datastore, if the backing 
device is *really* a removable device

* At the moment only the UUID of the FS is shown in the Options tab. 
Perhaps also showing the configured backing path (=mount point) would 
also be an option. I think, humans can handle short paths a bit better 
than "random" uuids ;)

(tested with virtual disks and a physical usb stick)

Other comments, not related to this series:

* I was not able to find the "Remove Datastore" button myself – I simply 
didn't see it. It blew my mind, when Hannes showed me this button :P

On 19.08.21 13:03, Hannes Laimer wrote:
> Adds the possibility to create removable datastores. A removable
> datastore has a UUID(the device on which the data is stored) and a
> mount-point(where the device will be mounted), iff both are set the
> datastore is removable. Everything else is identical to normal
> datastores. Since config files for jobs, etc. are stored on the server,
> all configuration can be done with the device plugged in or not. Certain
> statistics about the datastore won't be available as long as it is not
> plugged in.
> Removable datastores have to be unmounted before removing, it can only
> be unmounted if not jibs are running.
> Removable datastores are mounted automatically when the device is plugged in, if it has
> been unmounted, it has to be mounted manually through the WebUI or the Api.
> Jobs will not be started if the datastore is not available, and
> depending on the configuration, start when the device is plugged in the
> next time.
>
> Still todo:
>   - make sync to local datastore more integrated
>   - (add 'when plugged in'-option to job schedule?)
>   - replace linux commands with internal functions in tools/disks, where
>      possible
>
> Hannes Laimer (15):
>    tools: add disks utility functions
>    config: add uuid+mountpoint to DataStoreConfig
>    api2: add support for removable datastore creation
>    backup: add check_if_available function to ds
>    api2: add 'is_available' to DataStoreConfig
>    api2: add 'removable' to DataStoreListItem
>    api2: add (un)mount endpoint for removable ds's
>    pbs: add mount-removable command to commandSocket
>    pbs-manager: add 'send-command' command
>    debian: add udev rule for removable datastores
>    ui: show usb icon for removable datastore in list
>    ui: add 'removable' checkbox in datastore creation
>    ui: display row as disabled in ds statistics
>    ui: show backing device UUID in option tab
>    ui: add (un)mount button to summary
>
>   debian/proxmox-backup-server.udev    |   3 +
>   pbs-api-types/src/lib.rs             |   7 ++
>   src/api2/admin/datastore.rs          | 159 +++++++++++++++++++++++++++
>   src/api2/config/datastore.rs         |  19 +++-
>   src/api2/status.rs                   |  19 +++-
>   src/api2/types/mod.rs                |   2 +
>   src/backup/datastore.rs              |  23 ++++
>   src/backup/mod.rs                    |   2 +-
>   src/bin/proxmox-backup-api.rs        |  27 +++++
>   src/bin/proxmox-backup-manager.rs    |  41 +++++++
>   src/config/datastore.rs              |  16 +++
>   src/tools/disks/mod.rs               |  53 +++++++++
>   www/NavigationTree.js                |   3 +-
>   www/dashboard/DataStoreStatistics.js |   3 +
>   www/datastore/OptionView.js          |   3 +
>   www/datastore/Summary.js             |  77 ++++++++++++-
>   www/window/DataStoreEdit.js          |   5 +
>   17 files changed, 454 insertions(+), 8 deletions(-)
>