From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Gabriel Goller <g.goller@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] ui: add consent banner maxLength
Date: Mon, 9 Dec 2024 12:29:02 +0100 [thread overview]
Message-ID: <6762bcfb-a61e-4ad6-a9ed-9d3f882e41ff@proxmox.com> (raw)
In-Reply-To: <20241206122357.181200-1-g.goller@proxmox.com>
Am 06.12.24 um 13:23 schrieb Gabriel Goller:
> Add a maxLength of 24000 to the consentBanner. This is the same limit as
> in PVE, and while it makes sense there (file size limits in pmxcfs), it
> acts more as an arbitrary stop-gap here.
>
> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> ---
> www/config/NodeOptionView.js | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/www/config/NodeOptionView.js b/www/config/NodeOptionView.js
> index c327356f7f24..966e6d719469 100644
> --- a/www/config/NodeOptionView.js
> +++ b/www/config/NodeOptionView.js
> @@ -59,6 +59,9 @@ Ext.define('PBS.NodeOptionView', {
> name: 'consent-text',
> text: gettext('Consent Text'),
> deleteEmpty: true,
> + fieldOpts: {
> + maxLength: 24000,
But that's frontend only? So not really a limitation for anybody.
While it is great to have for UX, the real check should go into
the backend.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-12-09 11:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 12:23 Gabriel Goller
2024-12-09 11:29 ` Thomas Lamprecht [this message]
2024-12-10 10:25 ` Gabriel Goller
2024-12-10 10:27 ` Gabriel Goller
2024-12-10 10:36 ` Gabriel Goller
2024-12-10 15:48 ` Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6762bcfb-a61e-4ad6-a9ed-9d3f882e41ff@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox