public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 3/3] ui: datastore content: add action to show upload statistics
Date: Mon, 27 Nov 2023 13:06:00 +0100	[thread overview]
Message-ID: <66fbb58b-1c99-4c06-bf6a-ea308ee6fdd3@proxmox.com> (raw)
In-Reply-To: <5c7c34b9-2729-417e-82b4-25b77853d910@proxmox.com>

On 27.11.23 11:15, Dominik Csapak wrote:
> On 11/27/23 11:07, Thomas Lamprecht wrote:
>> On 27.11.23 10:28, Thomas Lamprecht wrote:
>>> we'd not add a core UI element for a rather niche information
>>> that most won't look at often.
>>
>> re-thinking this, maybe we want to put those things into a context
>> menu and expose that menu with a fa-bars or fa-toggle-down icon,
>> in addition with allowing one to trigger it with a standard right
>> click context menu (I wanted to add that for datastore content UI
>> since quite a while already).
> 
> sure, doesn't sound too complicated. i'd put the remaining actions
> also there. would you then still prefer a "general info" panel
> over just showing the upload statistics? (i guess so, but want
> to make sure)

Yes, and I'd also like that this is split (patch-wise) a bit so that
we do not have to use all or nothing now.

I.e., add context menu for existing actions and wire it up to right
click, that on it's own is a nice feature and doesn't needs anything
else mixed in.

Then add the new info thingy and add it only there for now.

Then rework a few of the existing actions out and add a (possibly
slightly filtered) fa-bars trigger-able menu there). IMO while the
other ones are relatively clear, this one has the most potential
for different opinion and UX workflow design and I'd not like to
being forced to rush that if I want the other (above) features now
already.





      reply	other threads:[~2023-11-27 12:06 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-01  9:29 [pbs-devel] [RFC PATCH proxmox-backup 0/3] show upload statistics in gui Dominik Csapak
2023-08-01  9:29 ` [pbs-devel] [RFC PATCH proxmox-backup 1/3] api-types: make UploadStatistic an api type Dominik Csapak
2023-11-27  9:52   ` Thomas Lamprecht
2023-11-27 10:01     ` Dominik Csapak
2023-11-27 10:12       ` Thomas Lamprecht
2023-11-27 10:17         ` Dominik Csapak
2023-11-27 12:44           ` Wolfgang Bumiller
2023-11-27 14:57             ` Dominik Csapak
2023-08-01  9:29 ` [pbs-devel] [RFC PATCH proxmox-backup 2/3] api: datastore: add upload_statistic to snapshot listing Dominik Csapak
2023-11-27  9:08   ` Wolfgang Bumiller
2023-08-01  9:29 ` [pbs-devel] [PATCH proxmox-backup 3/3] ui: datastore content: add action to show upload statistics Dominik Csapak
2023-11-27  9:28   ` Thomas Lamprecht
2023-11-27 10:04     ` Dominik Csapak
2023-11-27 10:27       ` Thomas Lamprecht
2023-11-27 10:33         ` Dominik Csapak
2023-11-27 12:02           ` Thomas Lamprecht
2023-11-27 12:08             ` Dominik Csapak
2023-11-27 10:07     ` Thomas Lamprecht
2023-11-27 10:15       ` Dominik Csapak
2023-11-27 12:06         ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=66fbb58b-1c99-4c06-bf6a-ea308ee6fdd3@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal