From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>, Stefan Sterz <s.sterz@proxmox.com>,
Wolfgang Bumiller <w.bumiller@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] fix #4521: api/tasks: replace upid as filename for task log downloads
Date: Thu, 9 Feb 2023 17:59:44 +0100 [thread overview]
Message-ID: <6632febf-c30a-8796-e941-cd5f2d9e471a@proxmox.com> (raw)
In-Reply-To: <b7261f9d-2d97-bd8b-0388-7765b4353ca1@proxmox.com>
On 09/02/2023 15:18, Stefan Sterz wrote:
>> It contains colons which seem to be turned to spaces by my browser.
>> Colons in http headers are a bit weird?
Colons are fine in HTTP header, they don't add any ambiguity on it's own as header
key's are the part from start of line to the _first_ colon.
The RFCs (7231 or the updated 9110) allow all printable ASCII chars (0x21 to 0x7E).
In fact, if I use `curl -OJ`, telling it to use the content-disposition header, it
does the right thing and safes the file correctly, preserving colons.
FWICT it's really just due to Windows limitations w.r.t. file naming that the
browser seemingly spread to all platforms (possibly to avoid that Linux user
passing files to Windows users breaks) - maybe open a bug there? x)
>> Maybe we should just strip them out or replace them with underscores or
>> something?
> underscores sound good to me.
>
meh... if, we'd need to adapt PVE again, there I already applied this.
next prev parent reply other threads:[~2023-02-09 16:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 11:41 Stefan Sterz
2023-02-09 14:16 ` Wolfgang Bumiller
2023-02-09 14:18 ` Stefan Sterz
2023-02-09 16:59 ` Thomas Lamprecht [this message]
2023-02-10 8:43 ` Wolfgang Bumiller
2023-03-28 12:00 ` [pbs-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6632febf-c30a-8796-e941-cd5f2d9e471a@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=s.sterz@proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox