From: Christian Ebner <c.ebner@proxmox.com>
To: Maximiliano Sandoval <m.sandoval@proxmox.com>,
pbs-devel@lists.proxmox.com
Subject: Re: [PATCH backup v3 2/3] docs: client: document further password constrains
Date: Wed, 4 Mar 2026 09:44:31 +0100 [thread overview]
Message-ID: <65d19be4-8ee5-41b1-ae93-88f435035ac8@proxmox.com> (raw)
In-Reply-To: <20260223093710.36009-3-m.sandoval@proxmox.com>
one nit inline
On 2/23/26 10:37 AM, Maximiliano Sandoval wrote:
> We leave the explicit newlines as "control character" might not mean
> much to some readers.
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> docs/backup-client.rst | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/docs/backup-client.rst b/docs/backup-client.rst
> index 40962f0e2..03a383d9c 100644
> --- a/docs/backup-client.rst
> +++ b/docs/backup-client.rst
> @@ -104,9 +104,10 @@ Environment Variables
> wireguard, instead of using an HTTP proxy.
>
>
> -.. Note:: Passwords must be valid UTF-8 and may not contain newlines. For your
> - convenience, Proxmox Backup Server only uses the first line as password, so
> - you can add arbitrary comments after the first newline.
> +.. Note:: Passwords must be valid UTF-8 and may not contain newlines or any
> + control characters in general. For your convenience, Proxmox Backup Server
nit: I suggest to drop the ` in general` here or even rephrase to `may
not contain any control characters or newlines.`. The `in general` makes
it less concise IMO, without providing additional relevant information.
> + only uses the first line as password, so you can add arbitrary comments after
> + the first newline.
>
>
> System and Service Credentials
next prev parent reply other threads:[~2026-03-04 8:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 9:37 [PATCH backup v3 0/3] fix #7054: client: remove trailing newlines from credentials Maximiliano Sandoval
2026-02-23 9:37 ` [PATCH backup v3 1/3] " Maximiliano Sandoval
2026-03-04 8:40 ` Christian Ebner
2026-02-23 9:37 ` [PATCH backup v3 2/3] docs: client: document further password constrains Maximiliano Sandoval
2026-03-04 8:44 ` Christian Ebner [this message]
2026-02-23 9:37 ` [PATCH backup v3 3/3] client: rename password to blob Maximiliano Sandoval
2026-03-04 8:49 ` Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65d19be4-8ee5-41b1-ae93-88f435035ac8@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox