public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dietmar Maurer <dietmar@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	 Wolfgang Bumiller <w.bumiller@proxmox.com>,
	Stefan Sterz <s.sterz@proxmox.com>
Subject: Re: [pbs-devel] [RFC PATCH 0/5] fix #3935: refactor datastore locking to use tmpfs
Date: Tue, 22 Mar 2022 10:46:20 +0100 (CET)	[thread overview]
Message-ID: <652219984.1036.1647942380429@webmail.proxmox.com> (raw)

> - A "hashmap lock file": An in-memory file filled with robust-futex
>   where the group name simply gets hashed to get to a positioin in the
>   file. Hash clashes aren't an issue since all they'd do is cause
>   multiple groups to be guarded by the same lock, which wouldn't
>   technically be wrong.

Just want to note that above approach could lead to unexpected deadlocks with hash clashes, so I guess it is not that simple to get it right...




             reply	other threads:[~2022-03-22  9:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-22  9:46 Dietmar Maurer [this message]
2022-03-22  9:57 ` Wolfgang Bumiller
  -- strict thread matches above, loose matches on Subject: below --
2022-03-18 14:06 Stefan Sterz
2022-03-22  9:38 ` Wolfgang Bumiller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=652219984.1036.1647942380429@webmail.proxmox.com \
    --to=dietmar@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=s.sterz@proxmox.com \
    --cc=w.bumiller@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal