public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Stefan Hanreich <s.hanreich@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 1/1] client: fix example commands for client usage
Date: Tue, 26 Nov 2024 12:12:42 +0100	[thread overview]
Message-ID: <645e40b1-5b8a-4620-b3d3-fb1c19cf87bd@proxmox.com> (raw)
In-Reply-To: <20241126110428.71348-1-s.hanreich@proxmox.com>

Am 26.11.24 um 12:04 schrieb Stefan Hanreich:
> The example commands in the Change Detection Mode / File Exclusion
> section are missing the command in the client invocation. Add the
> backup command to the examples, so they are actually valid.
> 
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> ---
>  docs/backup-client.rst | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/docs/backup-client.rst b/docs/backup-client.rst
> index 3c6941ae..f2b5273c 100644
> --- a/docs/backup-client.rst
> +++ b/docs/backup-client.rst
> @@ -272,13 +272,13 @@ parameter. For example:
>  
>  .. code-block:: console
>  
> -    # proxmox-backup-client backup.pxar:./linux --exclude /usr
> +    # proxmox-backup-client backup backup.pxar:./linux --exclude /usr
>  
>  Multiple paths can be excluded like this:
>  
>  .. code-block:: console
>  
> -    # proxmox-backup-client backup.pxar:./linux --exclude=/usr --exclude=/rust
> +    # proxmox-backup-client backup backup.pxar:./linux --exclude=/usr --exclude=/rust
>  
>  .. _client_change_detection_mode:
>  
> @@ -329,7 +329,7 @@ mode:
>  
>  .. code-block:: console
>  
> -    # proxmox-backup-client backup.pxar:./linux --change-detection-mode=metadata
> +    # proxmox-backup-client backup backup.pxar:./linux --change-detection-mode=metadata

Fabian already applied this, but I'd also change the target pxar file name,
using "backup" for that is probably the the source  of the original mistake
and is IMO quite likely to confuse users, double words are often skipped
unconsciously by the brain (for some proven if they have missed the double
the in the second line ;)

>  
>  .. _client_encryption:
>  



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


  parent reply	other threads:[~2024-11-26 11:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-26 11:04 Stefan Hanreich
2024-11-26 11:09 ` [pbs-devel] applied: " Fabian Grünbichler
2024-11-26 11:12 ` Thomas Lamprecht [this message]
2024-11-26 11:29   ` [pbs-devel] " Stefan Hanreich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=645e40b1-5b8a-4620-b3d3-fb1c19cf87bd@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=s.hanreich@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal