From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup] file-restore: fix -blockdev regression with namespaces or encryption
Date: Tue, 10 Dec 2024 12:08:20 +0100 [thread overview]
Message-ID: <636c2347-866f-42a7-a9cc-d00a8cb2af9a@proxmox.com> (raw)
In-Reply-To: <20241210093750.217116-1-f.gruenbichler@proxmox.com>
Am 10.12.24 um 10:37 schrieb Fabian Grünbichler:
> these two were missed because they were not part of the "main" format string..
>
> Fixes: 668b8383 ("file restore: qemu helper: switch to more modern blockdev option for drives")
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
> proxmox-file-restore/src/qemu_helper.rs | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>
applied, with Mira's T-b, thanks!
I also tried to add some more context to the commit message, but this is not described
really well in QEMU options, there's a general "you need to double commas in filenames"
(which we do not check for? albeit not a problem as long as our volume names are used),
and some obvious but uncommented hints in the util/keyval.c key-value parser.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2024-12-10 11:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-10 9:37 [pbs-devel] " Fabian Grünbichler
2024-12-10 10:37 ` Mira Limbeck
2024-12-10 11:08 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=636c2347-866f-42a7-a9cc-d00a8cb2af9a@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox